[dovecot/core] 5774da: lib-storage: Fix SORT error message when reaching ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 5774da7bb2c1209904dd37f7cc08ecb9b4c5f572
      https://github.com/dovecot/core/commit/5774da7bb2c1209904dd37f7cc08ecb9b4c5f572
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-05 (Mon, 05 Jun 2017)

  Changed paths:
    M src/lib-storage/index/index-sort.c

  Log Message:
  -----------
  lib-storage: Fix SORT error message when reaching mail_sort_max_read_count

It should have been:
NO [LIMIT] Requested sort would have taken too long

Instead it was just:
NO [SERVERBUG] Mail field not cached

It was broken for CC, FROM, TO, SUBJECT, DISPLAYFROM and DISPLAYTO.
The numeric sorting was working correctly.


  Commit: 646800dd3bdf2992eadfbd4dac7a14dd729fe00b
      https://github.com/dovecot/core/commit/646800dd3bdf2992eadfbd4dac7a14dd729fe00b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-05 (Mon, 05 Jun 2017)

  Changed paths:
    M src/lib-storage/index/istream-mail.c

  Log Message:
  -----------
  lib-storage: Make sure istream-mail doesn't replace an existing storage error

I'm not aware of it actually having broken anything, so this is just for
extra safety.


  Commit: 1a229e3e15ed387208c13e7dfe56984becf90288
      https://github.com/dovecot/core/commit/1a229e3e15ed387208c13e7dfe56984becf90288
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M src/lib-storage/index/index-sort-string.c

  Log Message:
  -----------
  lib-storage: Sort code cleanup - pass node to index_sort_get_string()


  Commit: 91ede77590440f8613c477bac1b7336ca8928e87
      https://github.com/dovecot/core/commit/91ede77590440f8613c477bac1b7336ca8928e87
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M src/lib-storage/index/index-sort-string.c

  Log Message:
  -----------
  lib-storage: Sort code cleanup - Change index_sort_get_string() to return bool

None of the callers cared about the difference between "expunged" vs
"error".


  Commit: 0a6a527f0c42b5478d80ac53ab357885676fd516
      https://github.com/dovecot/core/commit/0a6a527f0c42b5478d80ac53ab357885676fd516
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M src/lib-storage/index/index-sort-string.c

  Log Message:
  -----------
  lib-storage: Optimize error handling for SORT

If a lot of mails have failed in a large mailbox, this check reduces the
CPU usage significantly.


  Commit: adef31eb09ce4092968afc81680524ffb626b21e
      https://github.com/dovecot/core/commit/adef31eb09ce4092968afc81680524ffb626b21e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M src/lib-index/mail-cache-lookup.c

  Log Message:
  -----------
  lib-index: mail_cache_get_missing_reason() - Minor code cleanup


  Commit: bd897f82a5d9b00ba256b462d2056c2dc7df257c
      https://github.com/dovecot/core/commit/bd897f82a5d9b00ba256b462d2056c2dc7df257c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M src/lib-index/mail-cache-lookup.c
    M src/lib-index/mail-cache-private.h

  Log Message:
  -----------
  lib-index: Add cache to mail_cache_get_missing_reason()

This avoids excessive CPU usage when it's called in a loop for many mails.


Compare: https://github.com/dovecot/core/compare/6f380c1e809a...bd897f82a5d9