[dovecot/core] 7d84da: auth: Access always first entry when flushing fail...

[GitHub]

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 7d84daaf54148aa977bd3a38fdd1b55032874c31
      https://github.com/dovecot/core/commit/7d84daaf54148aa977bd3a38fdd1b55032874c31
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M src/auth/auth-request-handler.c

  Log Message:
  -----------
  auth: Access always first entry when flushing failures

The code is deleting the first item after accessing
it, and then moving forward. It will eventually go
beyond the array and get NULL ptr and fail.

Instead we need to always get the first item,
since the array deletion is moving the queued items
forward.

Broken by e18b4e41


  Commit: 1d0a9371e5740e18d962a8bb803ac63220074cfb
      https://github.com/dovecot/core/commit/1d0a9371e5740e18d962a8bb803ac63220074cfb
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M src/plugins/push-notification/push-notification-driver-ox.c

  Log Message:
  -----------
  push-notification: Fix crash in OX driver's deinit

The http_client doesn't always exist.


Compare: https://github.com/dovecot/core/compare/215fd61e458f...1d0a9371e574