[dovecot/core] 5695ec: lib-mail: istream-header-filter - Fix HEADER_FILTE...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 5695ec03a0cc4836896e46a01bb9336782aee326
      https://github.com/dovecot/core/commit/5695ec03a0cc4836896e46a01bb9336782aee326
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-14 (Wed, 14 Jun 2017)

  Changed paths:
    M src/lib-mail/istream-header-filter.c
    M src/lib-mail/test-istream-header-filter.c

  Log Message:
  -----------
  lib-mail: istream-header-filter - Fix HEADER_FILTER_ADD_MISSING_EOH with empty input

The result for "" should be "\n", not "\n\n". The second "\n" would belong
to the mail body.

This fixes calculating hashes for incremental dsync when mail didn't have
Date or Message-ID headers, resulting in e.g.:

Warning: Deleting mailbox 'INBOX': UID=1 already exists locally for a different mail: Headers hashes don't match (e1c06d85ae7b8b032bef47e42e4c08f9 vs 68b329da9893e34099c7d8ad5cb9c940)


  Commit: 3da9825732c865b8ea11ea070e5b6f881ffae424
      https://github.com/dovecot/core/commit/3da9825732c865b8ea11ea070e5b6f881ffae424
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-14 (Wed, 14 Jun 2017)

  Changed paths:
    M src/lib-index/mail-cache-transaction.c

  Log Message:
  -----------
  lib-index: Fix cache lookups from uncommitted transactions with in-memory indexes

This especially fixes mail_get_header_stream() with imapc and
imapc_features=fetch-headers, because it works by first fetching the
specific headers and putting them to the cache transaction, then later on
relying on index_mail_get_header_stream() to get them from the transaction.
Before this fix they wouldn't be found, which triggered another unnecessary
FETCH BODY.PEEK[HEADER].


  Commit: df74814b12ef891a90522b1ced231350afaf1232
      https://github.com/dovecot/core/commit/df74814b12ef891a90522b1ced231350afaf1232
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-14 (Wed, 14 Jun 2017)

  Changed paths:
    M src/doveadm/dsync/dsync-mailbox-export.c

  Log Message:
  -----------
  dsync: Fix panic if syncing fails during attribute iteration

Fixes:
Panic: file dict.c: line 104 (dict_deinit): assertion failed: (dict->iter_count == 0)


Compare: https://github.com/dovecot/core/compare/159de4e2ce3f...df74814b12ef