[dovecot/core] 1ad320: lib-oauth2: Use http client destroy callback

Thu Mar 16 17:55:49 UTC 2017

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 1ad3209862c49d0f2d95a67753a6757799c89397
      https://github.com/dovecot/core/commit/1ad3209862c49d0f2d95a67753a6757799c89397
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-oauth2/oauth2-introspect.c
    M src/lib-oauth2/oauth2-refresh.c
    M src/lib-oauth2/oauth2-token-validate.c

  Log Message:
  -----------
  lib-oauth2: Use http client destroy callback

Avoids freeing memory early.

Fixes signal 11 crash in auth

  Commit: c9e9cfac848db4b67fdb711e61f4cfb4d1dfd266
      https://github.com/dovecot/core/commit/c9e9cfac848db4b67fdb711e61f4cfb4d1dfd266
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c

  Log Message:
  -----------
  db-oauth2: Make sure request is removed only once

Callback might be called twice.

  Commit: 7979af45b5e4461f649232cdab6032069ea1bbb7
      https://github.com/dovecot/core/commit/7979af45b5e4461f649232cdab6032069ea1bbb7
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-sasl/mech-oauthbearer.c

  Log Message:
  -----------
  lib-sasl: Fix xoauth2 data format

Authentication data was missing user=

  Commit: 1a7641cce2ba2b601ede1e1eb46a82f46c5f1ab3
      https://github.com/dovecot/core/commit/1a7641cce2ba2b601ede1e1eb46a82f46c5f1ab3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/imap/cmd-fetch.c

  Log Message:
  -----------
  imap: When disconnecting due to FETCH failure, include "FETCH" in the log message.

  Commit: 7d4b3c6acb10cbf0969f538c5c2a2d50dfdfb84a
      https://github.com/dovecot/core/commit/7d4b3c6acb10cbf0969f538c5c2a2d50dfdfb84a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/imap/imap-state.c

  Log Message:
  -----------
  imap: If unhibernation fails due to a mailbox error, log the mailbox name.

  Commit: be66ad91ed2cc14906e40400bdd912f93403ff57
      https://github.com/dovecot/core/commit/be66ad91ed2cc14906e40400bdd912f93403ff57
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  pop3: Set process title before syncing mailbox.

The syncing could be taking a long time, so it's useful to have the username
in the process title during that.

  Commit: 043aa65325dd28931258a9c8b6ed4bffaba60ef0
      https://github.com/dovecot/core/commit/043aa65325dd28931258a9c8b6ed4bffaba60ef0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/imap-urlauth/imap-urlauth-login.c
    M src/login-common/client-common-auth.c
    M src/login-common/client-common.c
    M src/login-common/client-common.h
    M src/login-common/login-proxy.c
    M src/pop3-login/client.c

  Log Message:
  -----------
  *-login: Add client.proxy_get_state() for providing human-readable proxy state

If not implemented, it defaults to the old method of returning proxy_state
number.

  Commit: e7d9dd003e6192b294507b9fbe9917a514e441f6
      https://github.com/dovecot/core/commit/e7d9dd003e6192b294507b9fbe9917a514e441f6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/imap-login/imap-login-client.c
    M src/imap-login/imap-login-client.h
    M src/imap-login/imap-proxy.c
    M src/imap-login/imap-proxy.h

  Log Message:
  -----------
  imap-login: Log proxy state as human-readable string.

Separate sent/received state and log them as strings.

  Commit: 7a690778e2d288338c66a2a7f70efa9a85578312
      https://github.com/dovecot/core/commit/7a690778e2d288338c66a2a7f70efa9a85578312
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/pop3-login/client.c
    M src/pop3-login/client.h
    M src/pop3-login/pop3-proxy.c
    M src/pop3-login/pop3-proxy.h

  Log Message:
  -----------
  pop3-login: Log proxy state as human-readable string.

  Commit: c386ebe04c47d60feab83a4b7bc17dfc984c0080
      https://github.com/dovecot/core/commit/c386ebe04c47d60feab83a4b7bc17dfc984c0080
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/pop3-login/client.h
    M src/pop3-login/pop3-proxy.c

  Log Message:
  -----------
  pop3-login: Remove usage of client.common.proxy_state

  Commit: 319959b042e6818be0410994a04851bb0d1c0b71
      https://github.com/dovecot/core/commit/319959b042e6818be0410994a04851bb0d1c0b71
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/login-common/client-common-auth.c
    M src/login-common/client-common.h

  Log Message:
  -----------
  *-login: Remove unused client.proxy_state

  Commit: 21d083ffb353b33f902a78f3f2781868fc457557
      https://github.com/dovecot/core/commit/21d083ffb353b33f902a78f3f2781868fc457557
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-dict.c

  Log Message:
  -----------
  auth: Do not double-expand key in passdb dict when authenticating

Broken by 79042f8c

  Commit: 68df507e448fe7d2c2bb885161a148b7caaf3e58
      https://github.com/dovecot/core/commit/68df507e448fe7d2c2bb885161a148b7caaf3e58
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c

  Log Message:
  -----------
  auth: oauth2 - Fix aborting auth requests on deinit.

The auth_request needs to be finished by calling the callback.

  Commit: e2065b361594e72dd30e4f660bfcb077416f1927
      https://github.com/dovecot/core/commit/e2065b361594e72dd30e4f660bfcb077416f1927
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c

  Log Message:
  -----------
  auth: oauth2 - Make sure db_oauth2_request.req is set to NULL when it gets freed.

Doesn't fix anything, but makes it clearer that req->req must not be
aborted anymore after this stage, because it gets freed anyway.

  Commit: 98fce39003a460d332c106d7c50a6908f54a4593
      https://github.com/dovecot/core/commit/98fce39003a460d332c106d7c50a6908f54a4593
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c

  Log Message:
  -----------
  auth: oauth2 - introspection lookup error should be internal failure

Not the default, which is "password mismatch".

  Commit: 3f1dde2d6dd324df0bbbcd3552a0d1d74b751523
      https://github.com/dovecot/core/commit/3f1dde2d6dd324df0bbbcd3552a0d1d74b751523
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c
    M src/auth/db-oauth2.h

  Log Message:
  -----------
  auth: oauth2 - make db_oauth2_template_export() static

It's not used outside db-oauth2.c

  Commit: 693b6f93dbe4cf6d5daabe72f63e2fca4f1d4ec0
      https://github.com/dovecot/core/commit/693b6f93dbe4cf6d5daabe72f63e2fca4f1d4ec0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c

  Log Message:
  -----------
  auth: oauth2 - Template expand failure should be an internal error

Not the default "password mismatch". Also changed the API to be closer to
the other nearby functions.

  Commit: 0aa06a246b503c25f12b729d8c01b564445616c6
      https://github.com/dovecot/core/commit/0aa06a246b503c25f12b729d8c01b564445616c6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c
    M src/auth/db-oauth2.h
    M src/auth/passdb-oauth2.c

  Log Message:
  -----------
  auth: oauth2 - remove db_oauth2_request.result

It's not a persistent state. When it's set, the callback needs to be called.
This way it's more difficult to forget to set it.

  Commit: 91ae7a2a4060e70e285f1e6408efdd31edeb2e75
      https://github.com/dovecot/core/commit/91ae7a2a4060e70e285f1e6408efdd31edeb2e75
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c
    M src/auth/db-oauth2.h
    M src/auth/passdb-oauth2.c

  Log Message:
  -----------
  auth: oauth2 - remove db_oauth2_request.failed

It is an unnecessary duplication of passdb_result.

  Commit: 92709fcc5f68084e7d7b3d12a86afc4e639c0885
      https://github.com/dovecot/core/commit/92709fcc5f68084e7d7b3d12a86afc4e639c0885
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c

  Log Message:
  -----------
  auth: oauth2 - Clarify token validation success/valid error handling

result->error is NULL only if result->success && !result->valid.
Also !result->success is the more important error handling case.
Write out these cases explicitly so it's easier to understand.

  Commit: 2eea5e3f5bb6592d1a5007a476134b0869c0f764
      https://github.com/dovecot/core/commit/2eea5e3f5bb6592d1a5007a476134b0869c0f764
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c

  Log Message:
  -----------
  auth: oauth2 - make it easier to see where db_oauth2_callback() is called

Doesn't fix anything, but places the db_oauth2_callback() calls into the end
of _continue() calls so it's clearer that they're always being called
exactly once.

  Commit: f72a75a57d11f9f691588e94bdaa84a2ef69fa13
      https://github.com/dovecot/core/commit/f72a75a57d11f9f691588e94bdaa84a2ef69fa13
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/db-oauth2.c
    M src/auth/db-oauth2.h
    M src/auth/passdb-oauth2.c

  Log Message:
  -----------
  auth: oauth2 - cleanup db_oauth2_lookup_callback_t

db parameter isn't needed, because request->db already contains it.
Also moved request parameter to be the first.

  Commit: 466217193ffb52300713b50ecca1fb345075b3f7
      https://github.com/dovecot/core/commit/466217193ffb52300713b50ecca1fb345075b3f7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-oauth2/oauth2-introspect.c
    M src/lib-oauth2/oauth2-private.h
    M src/lib-oauth2/oauth2-refresh.c
    M src/lib-oauth2/oauth2-token-validate.c
    M src/lib-oauth2/oauth2.c

  Log Message:
  -----------
  lib-oauth2: Fix memory leak if HTTP URL parsing fails.

Also delay calling the callback. The callers don't necessarily expect an
immediate callback (auth/db-oauth2.c doesn't).

  Commit: 45598d313a58eeefe1079cc8317899257fd581f5
      https://github.com/dovecot/core/commit/45598d313a58eeefe1079cc8317899257fd581f5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-oauth2/oauth2-introspect.c
    M src/lib-oauth2/oauth2-refresh.c
    M src/lib-oauth2/oauth2-token-validate.c

  Log Message:
  -----------
  lib-oauth2: Don't free oauth2_request too early.

Move the freeing explicitly to only after calling the callback. The
previous method of freeing it on when http_request was destroyed could
have happened too early when oauth2_parse_json() called i_stream_unref(),
which released the last reference to the http_request.

  Commit: 170f62e6e89c30f0d1b68465e7b23814e4d5bdf9
      https://github.com/dovecot/core/commit/170f62e6e89c30f0d1b68465e7b23814e4d5bdf9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  cassandra: Treat CASS_ERROR_SERVER_UNAVAILABLE as "write success is uncertain"

Looks like the write could still have actually gone through.

  Commit: 4325f1b85329ec7d7164b643e2ed24a32b762e1f
      https://github.com/dovecot/core/commit/4325f1b85329ec7d7164b643e2ed24a32b762e1f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/login-common/client-common.c
    M src/login-common/client-common.h
    M src/login-common/main.c

  Log Message:
  -----------
  *-login: Change API for how login_plugins hook into client allocation.

The previous API worked badly when there were more than one plugin.
The current behavior works similarly to how mail_plugins work.

  Commit: 3c87f3ede6c8503b46e525d507d20c16edbcf1cb
      https://github.com/dovecot/core/commit/3c87f3ede6c8503b46e525d507d20c16edbcf1cb
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/auth-client-connection.c

  Log Message:
  -----------
  auth: Properly hide all fields with passwords

client reply line wasn't hiding all items
which contain 'pass' substring. This was
inconsistent behaviour since elsewhere this was done.

  Commit: 3b9d623c0b6fd967991fb7887fa8c4c196e6b078
      https://github.com/dovecot/core/commit/3b9d623c0b6fd967991fb7887fa8c4c196e6b078
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/auth-worker-client.c

  Log Message:
  -----------
  auth: passdb/userdb lookups via auth-worker cached too much of the replies

Only the fields returned by the lookup itself were supposed to be cached.
This was especially problematic if the lookup via auth-worker didn't
uniquely identify the user. For example doing a passdb lookup for an
attribute shared by multiple users could have caused the reply to contain
the previous cached user's all extra fields.

  Commit: ad504875883fdc78c7567d72bddbb2810139b594
      https://github.com/dovecot/core/commit/ad504875883fdc78c7567d72bddbb2810139b594
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/auth/auth-request.c
    M src/auth/auth-request.h
    M src/auth/auth-worker-client.c
    M src/auth/passdb-blocking.c
    M src/auth/userdb-blocking.c

  Log Message:
  -----------
  auth: Auth workers shouldn't return username if it wasn't changed

This continues the previous fix where username was always added to
passdb/userdb cache, even if the username wasn't changed. That could have
resulted in wrongly changing usernames if the cache key didn't uniquely
identify the user.

  Commit: cc6a567ca5c8e1a57aa78d053b36cbdda6ee3fb8
      https://github.com/dovecot/core/commit/cc6a567ca5c8e1a57aa78d053b36cbdda6ee3fb8
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/pop3/pop3-client.c
    M src/pop3/pop3-client.h

  Log Message:
  -----------
  pop3: Add client.destroyed boolean

  Commit: 8590275ece826d76c38dccf84215ec86b205e1b5
      https://github.com/dovecot/core/commit/8590275ece826d76c38dccf84215ec86b205e1b5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/imap/imap-client.c
    M src/imap/main.c
    M src/indexer/master-connection.c
    M src/pop3/main.c
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  imap, pop3, indexer-worker: Add (deinit) to process title before autoexpunging runs.

lmtp should also do this, but it needs a bit larger changes.

  Commit: edab7ec20988aab18334a8ea684556a778b339c6
      https://github.com/dovecot/core/commit/edab7ec20988aab18334a8ea684556a778b339c6
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/doveadm/doveadm-mail.c
    M src/imap/imap-commands-util.c
    M src/lib-storage/mail-error.h

  Log Message:
  -----------
  lib-storage & imap: add MAIL_ERROR_UNAVAILABLE as [UNAVAILABLE]

[UNAVAILABLE] is defined in RFC 5530 and we were just missing a MAIL_ERROR_*
constant to make use of it.

  Commit: 07b27806c9574acc4b999e6591f97ddc9f8a7a6d
      https://github.com/dovecot/core/commit/07b27806c9574acc4b999e6591f97ddc9f8a7a6d
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-dcrypt/dcrypt-openssl.c

  Log Message:
  -----------
  lib-dcrypt: Add asserts

Fixes several static analysis reports

  Commit: 2f7bf1862d6228a04277497ba7a46d7c5072b682
      https://github.com/dovecot/core/commit/2f7bf1862d6228a04277497ba7a46d7c5072b682
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm: Do not crash doveadm-server if input file missing

save commands expects valid input file for it to work,
if we are not running for cli, and input file is not
provided, provide EINVAL error to caller via i_stream_error.

  Commit: 9e3c2654f5de70c0a55d2879a86caa83df47c86f
      https://github.com/dovecot/core/commit/9e3c2654f5de70c0a55d2879a86caa83df47c86f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-index/mail-index-transaction-update.c

  Log Message:
  -----------
  lib-index: Minor fix to day_first_uid updating

mktime() was getting a bit confused around day changes. Giving it only
year/month/day makes it less confused.

  Commit: 35b34705199ce22c6f2f3e3b9dc1d95b05aa088e
      https://github.com/dovecot/core/commit/35b34705199ce22c6f2f3e3b9dc1d95b05aa088e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-index/test-mail-index-transaction-update.c

  Log Message:
  -----------
  lib-index: Fix test-mail-index-transaction-update

It was broken with TZ=Australia/ACT. Fixing it seems too troublesome, so
just use TZ=UTC during the test.

  Commit: 8f02dfd839231ba5661092f4b75a743c3a937fae
      https://github.com/dovecot/core/commit/8f02dfd839231ba5661092f4b75a743c3a937fae
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/imap-hibernate/imap-client.c

  Log Message:
  -----------
  imap-hibernate: Support userdb in var_expand

  Commit: 3b5d60f0cf9b6f10a09061fb90afc93b4afd1041
      https://github.com/dovecot/core/commit/3b5d60f0cf9b6f10a09061fb90afc93b4afd1041
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/master/service-monitor.c

  Log Message:
  -----------
  master: Don't crash if master socket couldn't be re-opened after settings reload.

  Commit: 64c85d1687566eccf06595ed7275733d04820f90
      https://github.com/dovecot/core/commit/64c85d1687566eccf06595ed7275733d04820f90
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/master/service-listen.c

  Log Message:
  -----------
  master: Add missing error logging for master socket listening failure.

  Commit: d82bad3787af38001dc0d2673e0c67877065b4e3
      https://github.com/dovecot/core/commit/d82bad3787af38001dc0d2673e0c67877065b4e3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/master/service-listen.c

  Log Message:
  -----------
  master: Try to listen on master socket even if all services couldn't be listened to.

This could happen during a settings reload.

  Commit: 012969729f15b56177976e71ec57662a428beed5
      https://github.com/dovecot/core/commit/012969729f15b56177976e71ec57662a428beed5
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/plugins/trash/trash-plugin.c

  Log Message:
  -----------
  trash: Read settings after namespaces are loaded

Fixes Panic: file mail-namespace.c: line 709 (mail_namespace_find): assertion failed: (ns != NULL)

  Commit: 895a31a20313f1b1e2162524c039f4d4e291e619
      https://github.com/dovecot/core/commit/895a31a20313f1b1e2162524c039f4d4e291e619
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/imap-hibernate/imap-client.c

  Log Message:
  -----------
  imap-hibernate: Avoid using casts

  Commit: d7f6e4ab4352a04f7e64041dd9ca5ba42d2e0873
      https://github.com/dovecot/core/commit/d7f6e4ab4352a04f7e64041dd9ca5ba42d2e0873
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-ssl-iostream/iostream-openssl-context.c

  Log Message:
  -----------
  lib-ssl-iostream: Fix ambiguity with SSL settings

 - lib-ssl-iostream as client: Use only allow_invalid_cert. If it's not set, verify the server cert.
 - lib-ssl-iostream as server: If verify_client_cert=FALSE, don't ask for the client cert. Otherwise, ask for client cert but still allow it if allow_invalid_cert=TRUE.

  Commit: 3ad044975d9b9f3ec4f2cbf7ba8275f6633169e0
      https://github.com/dovecot/core/commit/3ad044975d9b9f3ec4f2cbf7ba8275f6633169e0
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-ssl-iostream/iostream-ssl.c

  Log Message:
  -----------
  lib-ssl-iostream: Ensure verify_remote_cert is true

Forgotten in 38424b8081a75be3ef93729fed4d30dbafca5885

  Commit: 058ae8da2cf431a833a1253f11c81a2aece2fcb7
      https://github.com/dovecot/core/commit/058ae8da2cf431a833a1253f11c81a2aece2fcb7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M doc/example-config/conf.d/10-logging.conf

  Log Message:
  -----------
  example-config: Update deliver_log_format comment

  Commit: a39b5b2852f27efcf584619112dee3189ed2fd81
      https://github.com/dovecot/core/commit/a39b5b2852f27efcf584619112dee3189ed2fd81
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/lib-http/test-http-server-errors.c

  Log Message:
  -----------
  lib-http: test-http-server-errors: Fixed logically dead code.

Problem reported by Coverity.

Compare: https://github.com/dovecot/core/compare/3f97702b106b...a39b5b2852f2