[dovecot/core] cb4d75: lib: Fix memory leak in test-istream-concat

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: cb4d75e1b821feb577cfe6236d692a992203014e
      https://github.com/dovecot/core/commit/cb4d75e1b821feb577cfe6236d692a992203014e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/lib/test-istream-concat.c

  Log Message:
  -----------
  lib: Fix memory leak in test-istream-concat


  Commit: e266d02220804645dae64e3939a4a677da584128
      https://github.com/dovecot/core/commit/e266d02220804645dae64e3939a4a677da584128
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.h
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Avoid infinite reconnection loops when retrying command fails

reconnect_command_count wasn't calculated correctly, because the SELECT and
potentially other following sync commands weren't included in it.


  Commit: bc3309d262b7e38e20446d302caea9a05888f6c1
      https://github.com/dovecot/core/commit/bc3309d262b7e38e20446d302caea9a05888f6c1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: If initial SELECT fails, don't resend it twice on reconnect.


  Commit: f4871975cf97533f9570323ee2ab9a39db7ff307
      https://github.com/dovecot/core/commit/f4871975cf97533f9570323ee2ab9a39db7ff307
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-sync.c

  Log Message:
  -----------
  imapc: Avoid resending duplicate FETCH when reconnecting during the initial sync


  Commit: 2e47584d767f86848212ad5089549d3bb01885ca
      https://github.com/dovecot/core/commit/2e47584d767f86848212ad5089549d3bb01885ca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/lib-imap/imap-parser.c

  Log Message:
  -----------
  lib-imap: imap_parser_unref() should always set parser=NULL

Not just when the last reference is cleared. This is how *_unref()s should
work everywhere in Dovecot. This fixes a bug in lib-imap-client where a
parser could have been accessed after it was already freed.


  Commit: 78aafd062427cb22e9cf57ff08ced5b08baf55b3
      https://github.com/dovecot/core/commit/78aafd062427cb22e9cf57ff08ced5b08baf55b3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-client.h
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/imapc-connection.h
    M src/lib-storage/index/imapc/imapc-mailbox.c
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: Fix infinite reconnection when server keeps sending corrupted state

When corrupted state was found, imapc_client_mailbox_reconnect() is called
to reconnect. This call skipped the normal "is it safe to reconnect?"
checks causing potentially infinite reconnections.


  Commit: 651630fe2c92b696197ca7558925153d891997ed
      https://github.com/dovecot/core/commit/651630fe2c92b696197ca7558925153d891997ed
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/imapc-connection.h

  Log Message:
  -----------
  lib-imap-client: Change server IP only on connect() failures

Also log an warning-level message about it. This is mainly useful to see
that a slow connection could be caused by a connect() timeout. Since more
IPs are still available, it's not yet an error.


  Commit: 6e853fdf3a5670a2eb2d57b059afcee7fb6cbd47
      https://github.com/dovecot/core/commit/6e853fdf3a5670a2eb2d57b059afcee7fb6cbd47
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: Fix assert-crash if server doesn't send EXISTS reply to SELECT

Fixes:
Panic: file imapc-sync.c: line 477 (imapc_sync_index): assertion failed: (mbox->sync_fetch_first_uid == 1)


  Commit: 7efe57b10e55b29d3e618fa8194c01a9093f0d07
      https://github.com/dovecot/core/commit/7efe57b10e55b29d3e618fa8194c01a9093f0d07
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: Make sure a valid UIDVALIDITY is returned by SELECT

Fixes errors such as:
Error: Synchronization corrupted index header (in-memory index): uidvalidity=0, but next_uid=9


Compare: https://github.com/dovecot/core/compare/17aeaeec37ef...7efe57b10e55