[dovecot/core] 67cbe5: lib-storage: Add mailbox-list-iter-private.h with ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 67cbe5d33fbb7e635120f1c9226c39e5dafc096a
      https://github.com/dovecot/core/commit/67cbe5d33fbb7e635120f1c9226c39e5dafc096a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/Makefile.am
    A src/lib-storage/list/mailbox-list-iter-private.h
    M src/lib-storage/list/mailbox-list-iter.c

  Log Message:
  -----------
  lib-storage: Add mailbox-list-iter-private.h with autocreate context structs

Needed for the following ACL change.


  Commit: ab7687e9b029a16a6d4f4542943811262387ae87
      https://github.com/dovecot/core/commit/ab7687e9b029a16a6d4f4542943811262387ae87
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/plugins/acl/Makefile.am
    M src/plugins/acl/acl-mailbox-list.c

  Log Message:
  -----------
  acl: Skip auto=create|subscribe mailboxes that don't have lookup-right

Removing them entirely from the boxes and box_sets arrays in the list
context treats them as if they weren't configured at all. This way they
don't need any other special code.


  Commit: f5836cc8a93f13c2aaecc8a5f1de6ec9488915b5
      https://github.com/dovecot/core/commit/f5836cc8a93f13c2aaecc8a5f1de6ec9488915b5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-iter-private.h
    M src/lib-storage/list/mailbox-list-iter.c

  Log Message:
  -----------
  lib-storage: Don't list duplicate autocreated mailboxes' parents


  Commit: d754fe4573cb7ceaac373b003509beb14c52f6ca
      https://github.com/dovecot/core/commit/d754fe4573cb7ceaac373b003509beb14c52f6ca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-iter.c

  Log Message:
  -----------
  lib-storage: Add \NoInferiors flag to autocreated mailboxes with mbox

Once the mailboxes get autocreated, the \NoInferiors flag is added anyway.


  Commit: d186a2391d98a3efa3fe1078879ef2798e169c29
      https://github.com/dovecot/core/commit/d186a2391d98a3efa3fe1078879ef2798e169c29
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index-iter.c

  Log Message:
  -----------
  lib-storage: Cleanup - Don't use ctx in iter_use_index()

Shrinks the following change.


  Commit: f8a67af9b7bde79c186e6b82ea200d7fcf85571b
      https://github.com/dovecot/core/commit/f8a67af9b7bde79c186e6b82ea200d7fcf85571b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index-iter.c
    M src/lib-storage/list/mailbox-list-index.h
    M src/lib-storage/mailbox-list-private.h

  Log Message:
  -----------
  lib-storage: Fix mailbox_list_index=yes + ACLs + auto=subscribe mailboxes

If the auto=subscribe mailbox didn't have a lookup ACL, it shouldn't have
been listed. This didn't work properly, because ACL plugin initialized the
autocreate_ctx only for the index iterator, while the autoboxes were
listed using the backend iterator. Fixed by not creating index iterator at
all when doing a passthrough iteration.


  Commit: 427250183664665c9067880c0dafa0203fb00ebc
      https://github.com/dovecot/core/commit/427250183664665c9067880c0dafa0203fb00ebc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-iter.c
    M src/lib-storage/mailbox-list-private.h

  Log Message:
  -----------
  lib-storage: Make mailbox_list_iter_init_autocreate() static again

It's no longer needed elsewhere.


  Commit: ad9a6d27cd065a502d165e4929e7227abd19063d
      https://github.com/dovecot/core/commit/ad9a6d27cd065a502d165e4929e7227abd19063d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/plugins/acl/acl-global-file.c

  Log Message:
  -----------
  acl: Global ACL file was parsed as if it was local ACL file

This caused some of the ACL handling not work exactly as expected.


  Commit: 348202a977aea7bf72aa0fb62ccfdd6dcc41cb03
      https://github.com/dovecot/core/commit/348202a977aea7bf72aa0fb62ccfdd6dcc41cb03
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-fs-flags.c

  Log Message:
  -----------
  lib-storage: fs_list_get_mailbox_flags() - Reorganize code

No functional changes.


  Commit: cea31bf9e588436588e06625c741c0a87de673f1
      https://github.com/dovecot/core/commit/cea31bf9e588436588e06625c741c0a87de673f1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-fs-flags.c

  Log Message:
  -----------
  lib-storage: fs_list_get_mailbox_flags() - Add comments


  Commit: 9e50448ea2513fe4edee9e14ddcb9bb031823f0f
      https://github.com/dovecot/core/commit/9e50448ea2513fe4edee9e14ddcb9bb031823f0f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-fs-flags.c

  Log Message:
  -----------
  lib-storage: fs_list_get_mailbox_flags() - Don't assume directories always have children.

This makes the directory handling code equivalent for type==UNKNOWN and
type==DIR.


  Commit: 9934242994745cb810b290e3127f6a75d89d2177
      https://github.com/dovecot/core/commit/9934242994745cb810b290e3127f6a75d89d2177
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-fs-flags.c

  Log Message:
  -----------
  lib-storage: fs_list_get_mailbox_flags() - Return mailbox files as selectable

Avoids a second stat() later on, which would do the same anyway.


  Commit: 3c56ce9f3960329db46340ce13c6b337849bbdf5
      https://github.com/dovecot/core/commit/3c56ce9f3960329db46340ce13c6b337849bbdf5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-fs-iter.c

  Log Message:
  -----------
  lib-storage: Fix ACL in parent mailbox potentially hiding its children.

fs_get_existence_info_flag() was only being called with LAYOUT=fs and
Maildir combination, so only it was broken if the parent mailbox wasn't
visible but its children were.


  Commit: 6263d367e80995c03d4bfdc5ec12b81640d55efe
      https://github.com/dovecot/core/commit/6263d367e80995c03d4bfdc5ec12b81640d55efe
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-fs-iter.c

  Log Message:
  -----------
  lib-storage: Fix LAYOUT=fs potentially not ignoring ACLs when requested

fs_get_existence_info_flag() was only being called with LAYOUT=fs and
Maildir combination. This mainly affected that combination when using
mailbox_list_index=yes and trying to list mailboxes with ACL checking
disabled.


Compare: https://github.com/dovecot/core/compare/e67df1f706da...6263d367e809