[dovecot/pigeonhole] 1e20fa: lib-sieve: util: edit-header: Fixed potential NULL...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/pigeonhole
  Commit: 1e20fa6c69a886a568f2c9811603ecb3d90e790c
      https://github.com/dovecot/pigeonhole/commit/1e20fa6c69a886a568f2c9811603ecb3d90e790c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-11-25 (Sat, 25 Nov 2017)

  Changed paths:
    M src/lib-sieve/util/edit-mail.c

  Log Message:
  -----------
  lib-sieve: util: edit-header: Fixed potential NULL dereference in edit_mail_istream_read().

The merge_from_parent() function may not actually read anything, potentially leaving the stream buffer unassigned.
Problem found by Coverity.


  Commit: c9cf5650246564115023c71eb17c92c106c26c6c
      https://github.com/dovecot/pigeonhole/commit/c9cf5650246564115023c71eb17c92c106c26c6c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-11-25 (Sat, 25 Nov 2017)

  Changed paths:
    M src/lib-sieve/util/edit-mail.c

  Log Message:
  -----------
  lib-sieve: util: edit-mail: Fixed potential NULL dereference in edit_mail_istream_seek().

Used the stream's cur_header field, rather than the local variable.
Problem found by Coverity.


  Commit: 972bafc44d8d7f933bf95bdde9e30bddc9530c9b
      https://github.com/dovecot/pigeonhole/commit/972bafc44d8d7f933bf95bdde9e30bddc9530c9b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-11-25 (Sat, 25 Nov 2017)

  Changed paths:
    M src/lib-managesieve/managesieve-parser.c

  Log Message:
  -----------
  lib-managesieve: managesieve-parser: Return error status in quoted string stream immediately.

Otherwise the error status is overwritten.
Problem found by Coverity.


  Commit: 81505779e7ead16a4bef3ddfc9d588c52cfd0b3c
      https://github.com/dovecot/pigeonhole/commit/81505779e7ead16a4bef3ddfc9d588c52cfd0b3c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-11-25 (Sat, 25 Nov 2017)

  Changed paths:
    M src/lib-sieve/sieve-actions.c

  Log Message:
  -----------
  lib-sieve: store action: Avoid NULL pointer dereference during rollback when transaction context is somehow unassigned.

This change matches the other transaction stages.
This will not currently happen though.
Reported by Coverity.


  Commit: 89f1d4ab18c2799b558655421e4a2e796267a5b0
      https://github.com/dovecot/pigeonhole/commit/89f1d4ab18c2799b558655421e4a2e796267a5b0
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-11-26 (Sun, 26 Nov 2017)

  Changed paths:
    M src/lib-sieve/plugins/enotify/mailto/uri-mailto.h

  Log Message:
  -----------
  lib-sieve: enotify extension: uri-mailto: Removed unused field.

It doesn't serve a purpose either, since parsing "from" address from URI is not allowed for notify mailto.


  Commit: fbedb2dbb14014200145a0237713625de9d3f1cc
      https://github.com/dovecot/pigeonhole/commit/fbedb2dbb14014200145a0237713625de9d3f1cc
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-11-26 (Sun, 26 Nov 2017)

  Changed paths:
    M src/lib-sieve-tool/sieve-tool.c
    M src/lib-sieve-tool/sieve-tool.h
    M src/lib-sieve/cmd-redirect.c
    M src/lib-sieve/ext-envelope.c
    M src/lib-sieve/ext-reject.c
    M src/lib-sieve/plugins/enotify/mailto/ntfy-mailto.c
    M src/lib-sieve/plugins/enotify/mailto/uri-mailto.c
    M src/lib-sieve/plugins/enotify/mailto/uri-mailto.h
    M src/lib-sieve/plugins/notify/cmd-notify.c
    M src/lib-sieve/plugins/notify/ext-notify-common.c
    M src/lib-sieve/plugins/notify/ext-notify-common.h
    M src/lib-sieve/plugins/subaddress/ext-subaddress.c
    M src/lib-sieve/plugins/vacation/cmd-vacation.c
    M src/lib-sieve/plugins/vnd.dovecot/report/cmd-report.c
    M src/lib-sieve/sieve-actions.c
    M src/lib-sieve/sieve-actions.h
    M src/lib-sieve/sieve-address-parts.c
    M src/lib-sieve/sieve-address-parts.h
    M src/lib-sieve/sieve-address-source.c
    M src/lib-sieve/sieve-address-source.h
    M src/lib-sieve/sieve-address.c
    M src/lib-sieve/sieve-address.h
    M src/lib-sieve/sieve-common.h
    M src/lib-sieve/sieve-config.h
    M src/lib-sieve/sieve-message.c
    M src/lib-sieve/sieve-message.h
    M src/lib-sieve/sieve-settings.c
    M src/lib-sieve/sieve-smtp.c
    M src/lib-sieve/sieve-smtp.h
    M src/lib-sieve/sieve-types.h
    M src/lib-sieve/sieve.c
    M src/plugins/imapsieve/ext-imapsieve-environment.c
    M src/plugins/imapsieve/imap-sieve.c
    M src/plugins/lda-sieve/Makefile.am
    M src/plugins/lda-sieve/lda-sieve-plugin.c
    M src/plugins/sieve-extprograms/sieve-extprograms-common.c
    M src/sieve-tools/sieve-filter.c
    M src/sieve-tools/sieve-test.c
    M src/testsuite/testsuite-message.c
    M src/testsuite/testsuite-message.h
    M src/testsuite/testsuite-smtp.c
    M src/testsuite/testsuite-smtp.h
    M src/testsuite/testsuite.c
    M tests/execute/smtp.svtest
    M tests/extensions/envelope.svtest
    M tests/extensions/reject/smtp.svtest

  Log Message:
  -----------
  Adjusted to the lib-smtp changes in Dovecot.

Now using struct smtp_address rather than sieve_address.
In some cases, struct message_address may prove to be more suitable, but this is the best fit for now.
Adjusted to the renamed fields in struct mail_deliver_context.


Compare: https://github.com/dovecot/pigeonhole/compare/6f31aa7286c4...fbedb2dbb140