[dovecot/core] 67445e: lib-storage: imapc_mailbox_get_selected_status() c...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 67445e2ac5a75d361d3c68eedcb9e1a3655440b8
      https://github.com/dovecot/core/commit/67445e2ac5a75d361d3c68eedcb9e1a3655440b8
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  lib-storage: imapc_mailbox_get_selected_status() can't fail - remove dead code


  Commit: 7f8033ffe13c1e89d734beca6d8fbb5f15dbff8b
      https://github.com/dovecot/core/commit/7f8033ffe13c1e89d734beca6d8fbb5f15dbff8b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/plugins/zlib/zlib-plugin.c

  Log Message:
  -----------
  zlib: zlib_mailbox_open_input() can't fail - remove dead code


  Commit: 85cf1c27bcb9b38831a3cb4267f9fc814396f7be
      https://github.com/dovecot/core/commit/85cf1c27bcb9b38831a3cb4267f9fc814396f7be
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/lib-storage/index/mbox/mbox-sync.c

  Log Message:
  -----------
  mbox: Remove unnecessary check from assert - move_diff is always negative here


  Commit: 52c3bd140aefa777c1421137e033615ae0a58e72
      https://github.com/dovecot/core/commit/52c3bd140aefa777c1421137e033615ae0a58e72
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/auth/db-ldap.c

  Log Message:
  -----------
  auth: LDAP request queue has no size limit anymore - remove dead code


  Commit: a2f8919f2dd3fd0a51a1b81a2c67e22552bd381a
      https://github.com/dovecot/core/commit/a2f8919f2dd3fd0a51a1b81a2c67e22552bd381a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/lib-test/test-common.c

  Log Message:
  -----------
  lib-test: Use i_unreached() for marking unreachable code in test fatal handler

This avoids a warning with static analyzer.


  Commit: c97cf486720998159fd7d8988bbed1a2be3be1c1
      https://github.com/dovecot/core/commit/c97cf486720998159fd7d8988bbed1a2be3be1c1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/lib-dict/dict-memcached.c

  Log Message:
  -----------
  dict-memcached: Response status may not be included in enum memcached_response

This helps at least static analyzers figure out that other statuses are
possible, although unexpected.


  Commit: 12c57531519d66e237e865c6ee3f7eadfe148550
      https://github.com/dovecot/core/commit/12c57531519d66e237e865c6ee3f7eadfe148550
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/auth/db-dict.c
    M src/auth/db-ldap.c
    M src/doveadm/dsync/dsync-mailbox-tree.c
    M src/lib-http/http-client-peer.c
    M src/lib-http/test-http-server-errors.c
    M src/lib-ldap/ldap-connection.c
    M src/lib-storage/index/imapc/imapc-list.c
    M src/lib-storage/index/index-mail.c
    M src/lib-storage/index/shared/shared-list.c
    M src/lib-storage/mail-search-mime.c
    M src/lib-storage/mail-search.c
    M src/lib/failures.c
    M src/lib/test-array.c
    M src/master/main.c

  Log Message:
  -----------
  global: Remove dead code

Found with clang static analyzer.


Compare: https://github.com/dovecot/core/compare/740657494c5c...12c57531519d