[dovecot/core] 3dc758: quota-clone: Always update dict

Thu Oct 5 20:43:55 EEST 2017

  Branch: refs/tags/2.2.33.rc1
  Home:   https://github.com/dovecot/core
  Commit: 3dc758622a83c1b858423da93711ed2fde201e81
      https://github.com/dovecot/core/commit/3dc758622a83c1b858423da93711ed2fde201e81
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/plugins/quota-clone/quota-clone-plugin.c

  Log Message:
  -----------
  quota-clone: Always update dict

ret_count and ret_bytes become zero if no quota rules
are specified, so we need to update the dict anyways.

Broken in 81d10aff29baede9ae4944d6c89790871123d11d

  Commit: 49a526355f539678af0257dff3db3bb3c83b6839
      https://github.com/dovecot/core/commit/49a526355f539678af0257dff3db3bb3c83b6839
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Fix tracking user move count when user is freed early

users_moving_count wasn't updated if the user was freed before killing it
finished. This caused "doveadm director flush" to hang while waiting for
the move count to drop to 0, which it never did. Also following flushes
were doing less work in parallel, or possibly even nothing since director
thought there were too many users already being moved.

  Commit: 5848bf10efc3562c66b8a933b11f46f5584f0a84
      https://github.com/dovecot/core/commit/5848bf10efc3562c66b8a933b11f46f5584f0a84
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/doveadm-connection.c

  Log Message:
  -----------
  director: Fix HOST-RESET-USERS when all hosts are down

If there were a lot of users being kicked, the host was flushed after the
initial round of user kills. This caused the rest of the user connections to
be just discarded instead of actually being killed.

  Commit: 7a4621110a964a8c6aa984c0314a1a887c374bdf
      https://github.com/dovecot/core/commit/7a4621110a964a8c6aa984c0314a1a887c374bdf
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/lib/Makefile.am
    A src/lib/istream-multiplex.c
    A src/lib/istream-multiplex.h
    A src/lib/ostream-multiplex.c
    A src/lib/ostream-multiplex.h
    A src/lib/test-istream-multiplex.c
    M src/lib/test-lib.c
    M src/lib/test-lib.h
    A src/lib/test-multiplex.c
    A src/lib/test-ostream-multiplex.c

  Log Message:
  -----------
  lib: Add multiplex stream support

This allows having multiple channels of data in single stream.

  Commit: 2cb630d7dda92e907e412a416c4c0fb256c98a7e
      https://github.com/dovecot/core/commit/2cb630d7dda92e907e412a416c4c0fb256c98a7e
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection.c
    M src/doveadm/client-connection.h
    M src/doveadm/doveadm-util.h
    M src/doveadm/server-connection.c

  Log Message:
  -----------
  doveadm-server: Refactor connection handshake and authentication

Simplifies next change

  Commit: 6960662b27ebd6ce3a5dd45d9cebac901d1002d4
      https://github.com/dovecot/core/commit/6960662b27ebd6ce3a5dd45d9cebac901d1002d4
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection.c
    M src/doveadm/doveadm-util.h
    M src/doveadm/server-connection.c

  Log Message:
  -----------
  doveadm: Refactor server/client code to support versioning properly

This way we can distinguish between old and new server side

  Commit: 7daf9f4648cbd255dc6d9fad8f9e0b9a66a755b7
      https://github.com/dovecot/core/commit/7daf9f4648cbd255dc6d9fad8f9e0b9a66a755b7
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection.c
    M src/doveadm/client-connection.h
    M src/doveadm/doveadm-util.c
    M src/doveadm/doveadm-util.h
    M src/doveadm/server-connection.c

  Log Message:
  -----------
  doveadm: Deliver remote logs over doveadm socket

  Commit: e9910418ac5badf7cf82c1f73d1678ed02a686cb
      https://github.com/dovecot/core/commit/e9910418ac5badf7cf82c1f73d1678ed02a686cb
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/lib/buffer.h

  Log Message:
  -----------
  lib: Fix warning with gcc7's -Wint-in-bool-context

  Commit: 71a491318b4b3c5c9d20ca2d96ebde3a223fccc9
      https://github.com/dovecot/core/commit/71a491318b4b3c5c9d20ca2d96ebde3a223fccc9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/lib-master/master-service-private.h
    M src/lib-master/master-service.c
    M src/lib-master/master-service.h

  Log Message:
  -----------
  lib-master: master_service_init_log() - Switch log handlers only on the first call

The secondary calls were only done by mail_storage_service_*() calls. They
want to initialize the logging once, but afterwards they only care about
changing the log prefix. Switch to this behavior now explicitly.

This fixes behavior if logging functions are changed between
mail_storage_service_*() calls, so they don't get reset.

  Commit: 86a787a082b0006b6b0ed4671bbc714755957806
      https://github.com/dovecot/core/commit/86a787a082b0006b6b0ed4671bbc714755957806
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director.c
    M src/director/doveadm-connection.c

  Log Message:
  -----------
  doveadm director ring remove: Wait ring sync before and after removal

This helps mainly with automated tests.

  Commit: c78c950ef8d094066942914ac706d34a9c1bb429
      https://github.com/dovecot/core/commit/c78c950ef8d094066942914ac706d34a9c1bb429
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: When logging "ring SYNC lost", include sync seq number in message

This can help with debugging.

  Commit: f16eeebdd5870f48535c801c41f78a07030c2f86
      https://github.com/dovecot/core/commit/f16eeebdd5870f48535c801c41f78a07030c2f86
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Improve debugging: Log ring desync when there is no right connection

  Commit: 2ff32179d88fa3463d6897ef74581e0af304f89f
      https://github.com/dovecot/core/commit/2ff32179d88fa3463d6897ef74581e0af304f89f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director-connection.c
    M src/director/director.c
    M src/director/director.h
    M src/director/doveadm-connection.c

  Log Message:
  -----------
  director: Log info line whenever a director is added/removed from ring

This can help with debugging problems.

  Commit: 4f8ec7760b231ef970c280790dc125f5e60523e4
      https://github.com/dovecot/core/commit/4f8ec7760b231ef970c280790dc125f5e60523e4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Cleanup - move code to a new director_log_connect()

Also adds a missing ')' to the log line.

  Commit: cc4257614b13e9b400c56880f83ab0dfbc8f2b2b
      https://github.com/dovecot/core/commit/cc4257614b13e9b400c56880f83ab0dfbc8f2b2b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director-connection.c
    M src/director/director.c
    M src/director/director.h
    M src/director/main.c

  Log Message:
  -----------
  director: Log info line for every incoming/outgoing connection

This can help with debugging problems.

  Commit: 1c88cb7429c7b56e03673788b01f13d05b4b2768
      https://github.com/dovecot/core/commit/1c88cb7429c7b56e03673788b01f13d05b4b2768
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director-connection.c

  Log Message:
  -----------
  director: Don't reset directors' last_network_failure while handshaking

The reset is done mainly to make it faster for a director that has been down
to connect back to the ring, without other directors still thinking that
it's down. But DIRECTOR that is sent during handshake says nothing about
whether the director is up at the moment or not.

  Commit: 63818a815986ea836b856f6794a5bd17de0dd903
      https://github.com/dovecot/core/commit/63818a815986ea836b856f6794a5bd17de0dd903
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: When director is removed, notify it before disconnecting

This way the removed director will know that it's been removed, and it
can also more quickly forward the removal to other directors.

  Commit: 3284bc936567cd5d497e1e7823bab98a1dc54613
      https://github.com/dovecot/core/commit/3284bc936567cd5d497e1e7823bab98a1dc54613
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director-connection.c

  Log Message:
  -----------
  director: After CONNECT was received, make sure we disconnect

The remote side won't be reading anything after the CONNECT, so we have to
disconnect anyway. If we decide that the CONNECT request is wrong, reconnect
after a short delay and hope that the remote agrees with us the next time.

  Commit: 656b9cd7f15c0e379a0a35eaa97459ab5919724b
      https://github.com/dovecot/core/commit/656b9cd7f15c0e379a0a35eaa97459ab5919724b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director-connection.c

  Log Message:
  -----------
  director: Ignore CONNECT requests to hosts that have been removed already

  Commit: 959376d04da2eb161e911f0a914bba7d86f4cc9e
      https://github.com/dovecot/core/commit/959376d04da2eb161e911f0a914bba7d86f4cc9e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/doveadm-connection.c

  Log Message:
  -----------
  director: Fix ring sync wait after DIRECTOR-REMOVE

It was sending OK twice, and the first OK was too early.

  Commit: 547fa7e595c2af1b93408936889d9d194edd552a
      https://github.com/dovecot/core/commit/547fa7e595c2af1b93408936889d9d194edd552a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director-connection.c

  Log Message:
  -----------
  director: Don't crash if DIRECTOR-REMOVE is received for itself

This triggers the director removal from the ring, which causes the
connection to be destroyed. But since we're still in the middle of handling
the connection it needs refcounting.

  Commit: 868c94dfa9bbda6fe527a7facab40cbfb3c2a06b
      https://github.com/dovecot/core/commit/868c94dfa9bbda6fe527a7facab40cbfb3c2a06b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/doveadm-connection.c

  Log Message:
  -----------
  director: Don't crash on doveadm director ring remove for unknown director

Ring syncing isn't started, so it shouldn't try to wait for ring sync.

Fixes:
Panic: file doveadm-connection.c: line 859 (doveadm_connection_cmd_run): assertion failed: (conn->dir->right == NULL && conn->dir->left == NULL)

  Commit: d78b8d04a30eda05a0c2f50e4f4a5c0f2cd63a79
      https://github.com/dovecot/core/commit/d78b8d04a30eda05a0c2f50e4f4a5c0f2cd63a79
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Allow doveadm director ring remove for the same director

Fixes:
Panic: file doveadm-connection.c: line 859 (doveadm_connection_cmd_run): assertion failed: (conn->dir->right == NULL && conn->dir->left == NULL)

  Commit: 184bcab00b008953ad8d869241709fbc664f0a58
      https://github.com/dovecot/core/commit/184bcab00b008953ad8d869241709fbc664f0a58
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Fix potential panic when director is alone

If director is alone and it can't connect to other directors, it might crash
with:

Panic: file director.c: line 318 (director_set_ring_synced): assertion failed: (!dir->ring_synced)

  Commit: ab9e658e626d28d0598e2dc983d2f28a48d09f1d
      https://github.com/dovecot/core/commit/ab9e658e626d28d0598e2dc983d2f28a48d09f1d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Rename director_delayed_dir_remove_timeout() to director_hosts_purge_removed()

This allows using it for other purposes without having a confusing name.

  Commit: f066ee1f0977f2e017f3fe927106c9622813e0a8
      https://github.com/dovecot/core/commit/f066ee1f0977f2e017f3fe927106c9622813e0a8
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: When ring is synced, purge any pending "removed" directors

This allows adding a director back to the ring without having to wait for 30
seconds.

  Commit: c1538be43b3f1f070f1487a732e821b559520231
      https://github.com/dovecot/core/commit/c1538be43b3f1f070f1487a732e821b559520231
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M NEWS
    M configure.ac

  Log Message:
  -----------
  Released v2.2.33.rc1.

Compare: https://github.com/dovecot/core/compare/3dc758622a83^...c1538be43b3f