[dovecot/core] e2a5de: lib-http: server: Make sure broken connection inpu...

Fri Oct 27 16:30:10 EEST 2017

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: e2a5de324df523512c42086d8422e4e41adf2c28
      https://github.com/dovecot/core/commit/e2a5de324df523512c42086d8422e4e41adf2c28
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/lib-http/http-server-request.c
    M src/lib-http/http-server-response.c

  Log Message:
  -----------
  lib-http: server: Make sure broken connection input always causes the connection to be closed after response.

  Commit: 359947c284ff1b4455cbacfe7b7bd9e3a2b50a87
      https://github.com/dovecot/core/commit/359947c284ff1b4455cbacfe7b7bd9e3a2b50a87
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/lib-http/http-server-response.c

  Log Message:
  -----------
  lib-http: server: Set `Connection:' header in response to `close' when request contains the same.

Before, it would set it to `Connection: keep-alive', which makes no sense.

  Commit: a5886aec87fbfd767a110e6168ce96411acfe798
      https://github.com/dovecot/core/commit/a5886aec87fbfd767a110e6168ce96411acfe798
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/lib-http/http-server-private.h
    M src/lib-http/http-server-request.c
    M src/lib-http/http-server-response.c
    M src/lib-http/http-server.h

  Log Message:
  -----------
  lib-http: server: Allow determining at any time whether the connection will be closed after handling a request.

Previously, this was only possible during response submission, which potentially requires making a `close' parameter available for any API function that submits a (failure) response.
This would become very ugly and inflexible.

  Commit: 001b7ca6a75e7052511420f9394ed7a7cf008f4a
      https://github.com/dovecot/core/commit/001b7ca6a75e7052511420f9394ed7a7cf008f4a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/lib-http/http-server-request.c
    M src/lib-http/http-server.h

  Log Message:
  -----------
  lib-http: server: Implemented http_server_request_fail_text(), which allows creating failure responses with verbose payload.

  Commit: 1b58508a918279d773ef32518f5d5d933023c252
      https://github.com/dovecot/core/commit/1b58508a918279d773ef32518f5d5d933023c252
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c
    M src/doveadm/client-connection-private.h
    M src/doveadm/client-connection.c
    M src/doveadm/client-connection.h
    M src/doveadm/doveadm-cmd.h
    M src/doveadm/doveadm-dsync.c
    M src/doveadm/doveadm-kick.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mail.h
    M src/doveadm/doveadm.c
    M src/plugins/mail-crypt/doveadm-mail-crypt.c

  Log Message:
  -----------
  doveadm: Changed command contexts to contain the input, output, and connection type values directly.

Before, it used a direct pointer to the connection.
It used also flags to indicate the connection type, which is now consolidated in the connection type enum.

  Commit: a435fb28fa05a589e40be2c313bd798f14846d06
      https://github.com/dovecot/core/commit/a435fb28fa05a589e40be2c313bd798f14846d06
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mail.h

  Log Message:
  -----------
  doveadm: mail: Removed struct doveadm_cmd_context function parameters that are now useless.

It can be accessed from struct doveadm_mail_cmd_context.

  Commit: 2ff59d50fe18864f3532004fbbcd98f371a6e22f
      https://github.com/dovecot/core/commit/2ff59d50fe18864f3532004fbbcd98f371a6e22f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/doveadm-dsync.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mail.h

  Log Message:
  -----------
  doveadm: mail: Removed redundant cur_client_ip field from struct doveadm_mail_cmd_context.

  Commit: e16f28d4b75e86b5e2d2ca8d3fd248f35f5051ef
      https://github.com/dovecot/core/commit/e16f28d4b75e86b5e2d2ca8d3fd248f35f5051ef
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection.c
    M src/doveadm/doveadm-dsync.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mail.h

  Log Message:
  -----------
  doveadm: mail: Removed redundant cur_username field from struct doveadm_mail_cmd_context.

  Commit: db4c6cc025e699aeecad87bf7cff08d12d4aff67
      https://github.com/dovecot/core/commit/db4c6cc025e699aeecad87bf7cff08d12d4aff67
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Moved loop body in doveadm_http_server_read_request_v1() to separate function.

  Commit: bf5c0995173a9e5ff0dcbd727c46b1051f36c88d
      https://github.com/dovecot/core/commit/bf5c0995173a9e5ff0dcbd727c46b1051f36c88d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Created local variable for conn->http_server_request as an abbreviation.

This also makes sure it is named consistently everywhere.
This is a preparation for subsequent commits.

  Commit: 28d5207fb7de5bc51f7367932341c467a4ed2dc4
      https://github.com/dovecot/core/commit/28d5207fb7de5bc51f7367932341c467a4ed2dc4
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Created local variable for conn->http_response as an abbreviation.

This also makes sure it is named consistently everywhere.
This is a preparation for subsequent commits.

  Commit: f17ff90e32712b2de1bb919560f673a56c2727bb
      https://github.com/dovecot/core/commit/f17ff90e32712b2de1bb919560f673a56c2727bb
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Created local variable for conn->http_request as an abbreviation.

This is a preparation for subsequent commits.

  Commit: 4b2c68685ac8bd7615c3bf57306e9c5d2ac59185
      https://github.com/dovecot/core/commit/4b2c68685ac8bd7615c3bf57306e9c5d2ac59185
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Created local variable for conn->client.output as an abbreviation.

This is a preparation for subsequent commits.

  Commit: a602aa85c991baaa2a89da5783b33373c66306ef
      https://github.com/dovecot/core/commit/a602aa85c991baaa2a89da5783b33373c66306ef
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Created local variable for conn->cmd_param->value.v_istream as an abbreviation.

This is a preparation for subsequent commits.

  Commit: df45032f2f7149c8254beb1a818e6c32acc1270d
      https://github.com/dovecot/core/commit/df45032f2f7149c8254beb1a818e6c32acc1270d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Cleaned up code formatting.

  Commit: 5381c92d04d810b063dc65324525c1f08115db08
      https://github.com/dovecot/core/commit/5381c92d04d810b063dc65324525c1f08115db08
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Use `ret' rather than `rc' as name for the local variable used for return values.

  Commit: 9cc49c886f0ad142735f0f1b47da8f19bd42e01b
      https://github.com/dovecot/core/commit/9cc49c886f0ad142735f0f1b47da8f19bd42e01b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Changed initialization of parameters in doveadm_http_handle_json_v1().

Use normal assignment, rather than memcpy().
This way, type checking is not skipped unnecessarily.

  Commit: e79e121745d3e75aa5f449f50d6439d6b1671763
      https://github.com/dovecot/core/commit/e79e121745d3e75aa5f449f50d6439d6b1671763
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Changed index variables from size_t to unsigned int where size_t makes no sense.

  Commit: c4292f96d02b283840f09206a269ad2bf029af9f
      https://github.com/dovecot/core/commit/c4292f96d02b283840f09206a269ad2bf029af9f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/Makefile.am
    A src/doveadm/client-connection-tcp.c
    R src/doveadm/client-connection.c

  Log Message:
  -----------
  doveadm-server: Renamed client-connection.c to client-connection-tcp.c.

Preparation for subsequent commits.

  Commit: 4e08875e53e96c8af3bfcb7c4aaa9c3a132101f8
      https://github.com/dovecot/core/commit/4e08875e53e96c8af3bfcb7c4aaa9c3a132101f8
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/Makefile.am
    M src/doveadm/client-connection-private.h
    M src/doveadm/client-connection-tcp.c
    A src/doveadm/client-connection.c

  Log Message:
  -----------
  doveadm-server: Moved common client code back from client-connection-tcp.c to client-connection.c.

  Commit: 57e356f6940a22747d0c809198232aefd235b840
      https://github.com/dovecot/core/commit/57e356f6940a22747d0c809198232aefd235b840
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-tcp.c

  Log Message:
  -----------
  doveadm-server: tcp: Cleaned up doveadm_server_log_handler().

  Commit: cd13c18ef29eb9793e04af44f039398359a548ba
      https://github.com/dovecot/core/commit/cd13c18ef29eb9793e04af44f039398359a548ba
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-tcp.c

  Log Message:
  -----------
  doveadm-server: tcp: Moved client_connection_destroy().

  Commit: 4284e4925ad29c4a403bb7375c3cdb411ed56736
      https://github.com/dovecot/core/commit/4284e4925ad29c4a403bb7375c3cdb411ed56736
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Renamed conn->client to conn->conn.

  Commit: f300f927771a39549ce6cb7607129508e9041b4a
      https://github.com/dovecot/core/commit/f300f927771a39549ce6cb7607129508e9041b4a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c
    M src/doveadm/client-connection.h
    M src/doveadm/main.c

  Log Message:
  -----------
  doveadm-server: http: Renamed client_connection_create_http() to client_connection_http_create().

  Commit: e60c3e17c656c53da60f0ac51aa15e9ef2742d77
      https://github.com/dovecot/core/commit/e60c3e17c656c53da60f0ac51aa15e9ef2742d77
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-tcp.c
    M src/doveadm/client-connection.h
    M src/doveadm/main.c

  Log Message:
  -----------
  doveadm-server: tcp: Renamed client_connection_create() to client_connection_tcp_create().

  Commit: ee063d66134c3ad0cec5e3919f7a0efe007406c6
      https://github.com/dovecot/core/commit/ee063d66134c3ad0cec5e3919f7a0efe007406c6
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Moved client_connection_destroy_http().

  Commit: 80a225c0b1f4bf322a562cc7c21d5891fb6895ee
      https://github.com/dovecot/core/commit/80a225c0b1f4bf322a562cc7c21d5891fb6895ee
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c
    M src/doveadm/client-connection-private.h
    M src/doveadm/client-connection-tcp.c
    M src/doveadm/client-connection.c
    M src/doveadm/client-connection.h
    M src/doveadm/main.c

  Log Message:
  -----------
  doveadm-server: Restructured client-connection code so that TCP and HTTP connection types are properly separated.

  Commit: 2045a5dff5368835a5c51c5cce93b5c5ad450949
      https://github.com/dovecot/core/commit/2045a5dff5368835a5c51c5cce93b5c5ad450949
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Renamed conn->http_client to conn->http_conn.

  Commit: 1a7d36f613f8e62bd27172c85d94b0d38a3e6c1c
      https://github.com/dovecot/core/commit/1a7d36f613f8e62bd27172c85d94b0d38a3e6c1c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Removed http_request field from struct client_connection_http.

Not useful to put it there.

  Commit: f607f622e93e5f570258205e79f9b0befc86dbd1
      https://github.com/dovecot/core/commit/f607f622e93e5f570258205e79f9b0befc86dbd1
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Renamed conn->http_server_request to conn->http_request.

  Commit: 8b24f7bd7be67dc54bbda16a41530d365c8fed59
      https://github.com/dovecot/core/commit/8b24f7bd7be67dc54bbda16a41530d365c8fed59
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Split authentication into multiple functions.

  Commit: bcb83bf89c33304f98a0dcd1e7f6bfc420e69a9f
      https://github.com/dovecot/core/commit/bcb83bf89c33304f98a0dcd1e7f6bfc420e69a9f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Create the http_response once needed, not preemptively.

  Commit: 3dee11217f10afbe6f28e89e4317b04db571c7fa
      https://github.com/dovecot/core/commit/3dee11217f10afbe6f28e89e4317b04db571c7fa
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Make http_server_set a local variable of doveadm_http_server_init().

  Commit: 437eb0a370b6b154c812d7d3d79ae36d9963d2f5
      https://github.com/dovecot/core/commit/437eb0a370b6b154c812d7d3d79ae36d9963d2f5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Moved connection-related code to the bottom of the file.

  Commit: 8bbeec794781ff89a2c4f175219600965bab8a8d
      https://github.com/dovecot/core/commit/8bbeec794781ff89a2c4f175219600965bab8a8d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Moved doveadm_http_server_send_response().

  Commit: 5927e94f41a54ceb2edf9f791f06db55fae6864b
      https://github.com/dovecot/core/commit/5927e94f41a54ceb2edf9f791f06db55fae6864b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Moved doveadm_http_server_request_destroy().

  Commit: 14e38f2900e9f49da471f9a4f1b4ab8908906fda
      https://github.com/dovecot/core/commit/14e38f2900e9f49da471f9a4f1b4ab8908906fda
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Added structural comments.

  Commit: 457869440af910388110dc5a58c4ab86b0f5a359
      https://github.com/dovecot/core/commit/457869440af910388110dc5a58c4ab86b0f5a359
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Split off request handling in separate struct, so that the connection can be reused.

  Commit: ce916cf4c7f29ffc8cc61205f1ee17b22e08c0cc
      https://github.com/dovecot/core/commit/ce916cf4c7f29ffc8cc61205f1ee17b22e08c0cc
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Renamed parse state enum.

  Commit: 664503c588de5db6ca138f90b3c7fa56352adcad
      https://github.com/dovecot/core/commit/664503c588de5db6ca138f90b3c7fa56352adcad
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Moved doveadm_http_server_command_execute().

  Commit: 2ccd63d6fc82558dd10c3bdc100653a16430f431
      https://github.com/dovecot/core/commit/2ccd63d6fc82558dd10c3bdc100653a16430f431
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-27 (Fri, 27 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Changed request parse error into an assertion.

The condition can never occur when json-parser and the request parsing state machine are behaving correctly.
At that point only an object key can be returned; the client cannot cause it to return anything else.

  Commit: e97a359e4f5aeb7fffe6f128800d816aecc983b5
      https://github.com/dovecot/core/commit/e97a359e4f5aeb7fffe6f128800d816aecc983b5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-27 (Fri, 27 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Split JSON parsing into several sub-functions.

  Commit: 39e011148a37f8baa6a78f0957e850d4faac8d02
      https://github.com/dovecot/core/commit/39e011148a37f8baa6a78f0957e850d4faac8d02
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-27 (Fri, 27 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Split JSON handling into several sub-functions.

  Commit: 2341eb700e9ec6309c7353c8e225c58c8e67b257
      https://github.com/dovecot/core/commit/2341eb700e9ec6309c7353c8e225c58c8e67b257
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-27 (Fri, 27 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Joined JSON parsing and handling in one function.

  Commit: 2511999c9323ca053291a785554c1f2236971b1d
      https://github.com/dovecot/core/commit/2511999c9323ca053291a785554c1f2236971b1d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-27 (Fri, 27 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Wrapped long code lines.

  Commit: 556a2028041de473e0c1380d0aef89dc3673f045
      https://github.com/dovecot/core/commit/556a2028041de473e0c1380d0aef89dc3673f045
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-27 (Fri, 27 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Restructured JSON parsing to improve code clarity.

Made state machine more explicit and easier to understand.
Also added more comments.

  Commit: 456e3b9c77f1a1bfc459bedfb8877684bac8f382
      https://github.com/dovecot/core/commit/456e3b9c77f1a1bfc459bedfb8877684bac8f382
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-27 (Fri, 27 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Mark the HTTP request for connection closure right away.

This means that the connection is closed once the request finishes.
Before, each response did that individually.
Once connection reuse is implemented/needed this can now be turned off at one place.

  Commit: cf6131bdaa0883f8e2c39843e301eae70cedb8de
      https://github.com/dovecot/core/commit/cf6131bdaa0883f8e2c39843e301eae70cedb8de
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-10-27 (Fri, 27 Oct 2017)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-server: http: Properly implemented error handling for requests.

Compare: https://github.com/dovecot/core/compare/68969d3f5b70...cf6131bdaa08