[dovecot/pigeonhole] f0963a: global: Replace str_append_n() with str_append_dat...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/pigeonhole
  Commit: f0963ac962bc87944a71aefc468bd57bc839f160
      https://github.com/dovecot/pigeonhole/commit/f0963ac962bc87944a71aefc468bd57bc839f160
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-25 (Wed, 25 Apr 2018)

  Changed paths:
    M src/lib-managesieve/managesieve-quote.c
    M src/lib-sieve/ext-encoded-character.c
    M src/lib-sieve/mcht-matches.c
    M src/lib-sieve/plugins/imap4flags/ext-imap4flags-common.c
    M src/lib-sieve/plugins/mime/cmd-extracttext.c
    M src/lib-sieve/plugins/notify/ext-notify-common.c
    M src/lib-sieve/plugins/regex/mcht-regex.c
    M src/lib-sieve/plugins/variables/ext-variables-arguments.c
    M src/lib-sieve/sieve-message.c
    M src/lib-sieve/storage/ldap/sieve-ldap-db.c
    M src/lib-sieve/util/edit-mail.c
    M src/lib-sieve/util/rfc2822.c
    M src/lib-sieve/util/test-edit-mail.c
    M src/managesieve-login/client-authenticate.c
    M src/testsuite/testsuite-arguments.c

  Log Message:
  -----------
  global: Replace str_append_n() with str_append_data().

The str_append_n() function is now deprecated. At no occasion, the occurence of
NUL in the data is possible or relevant, so each instance is replaced with
str_append_data() rather than str_append_max().


  Commit: 890c6e26d4f452304b2dfc10f6b71827198a7cbb
      https://github.com/dovecot/pigeonhole/commit/890c6e26d4f452304b2dfc10f6b71827198a7cbb
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-25 (Wed, 25 Apr 2018)

  Changed paths:
    M src/lib-sieve/util/edit-mail.c
    M src/lib-sieve/util/test-edit-mail.c

  Log Message:
  -----------
  lib-sieve: util: edit-mail: Fix assert panic occurring when streaming large headers.

The problem mainly arose because the stream buffer position was used to
determine how much was written, while the stream buffer position is potentially
decreased by i_stream_try_alloc().

Panic was:

Panic: file istream.c: line 197 (i_stream_read): assertion failed: ((size_t)ret+old_size == _stream->pos - _stream->skip)


Compare: https://github.com/dovecot/pigeonhole/compare/a82f2c3a1289...890c6e26d4f4