[dovecot/core] 0f73d2: lib-smtp: address parser: Do not allow source rout...

[GitHub]

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 0f73d2443cc6aafc0f26e6d9d84117f7bbff61d1
      https://github.com/dovecot/core/commit/0f73d2443cc6aafc0f26e6d9d84117f7bbff61d1
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/smtp-address.c
    M src/lib-smtp/test-smtp-address.c

  Log Message:
  -----------
  lib-smtp: address parser: Do not allow source route for path with omitted brackets.

Parse it strictly as a Mailbox, which makes more sense.


  Commit: 78101f0b4edcae2a477eda6f8fba3a0492ffa3a4
      https://github.com/dovecot/core/commit/78101f0b4edcae2a477eda6f8fba3a0492ffa3a4
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-mail.c
    M src/lib-smtp/smtp-server-cmd-rcpt.c
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: Add workarounds for well-known MAIL and RCPT command syntax deviations.


  Commit: 4cb2b08f864aa64b06f96e5cb6f0fe318fba6cd9
      https://github.com/dovecot/core/commit/4cb2b08f864aa64b06f96e5cb6f0fe318fba6cd9
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Use o_stream_nsend*() rather than o_stream_send*().

The result is not checked anyway.


  Commit: adfadd2077a24716357d39ce17d83c87fd904399
      https://github.com/dovecot/core/commit/adfadd2077a24716357d39ce17d83c87fd904399
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add support for client-side connection context data.


  Commit: d45a77f390e13d0f6479d5cb478f67c974712e4a
      https://github.com/dovecot/core/commit/d45a77f390e13d0f6479d5cb478f67c974712e4a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add log prefixes for client and server.

Makes it easier to distinguish which process is sending a log message while
debugging.


  Commit: a936583f5aad5392af78a033be7ce333d0dfe379
      https://github.com/dovecot/core/commit/a936583f5aad5392af78a033be7ce333d0dfe379
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Make detection of early termination of child processes part of each test.


  Commit: cc1252b8421ee3780bbad9122b2ce30e7f4200e1
      https://github.com/dovecot/core/commit/cc1252b8421ee3780bbad9122b2ce30e7f4200e1
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add more debug messages for the server.


  Commit: 044a32cef29b06d49ed0f5c76a61ca3b7ef206c9
      https://github.com/dovecot/core/commit/044a32cef29b06d49ed0f5c76a61ca3b7ef206c9
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Implicitly stop server when all expected client connections are closed.


  Commit: 479d716f2aef3e9f480018ef84c68856ec6d41f4
      https://github.com/dovecot/core/commit/479d716f2aef3e9f480018ef84c68856ec6d41f4
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add tests for bad MAIL command syntax.


  Commit: a425b5f82c8bc06bc2f809d2fee6c801d2b34d21
      https://github.com/dovecot/core/commit/a425b5f82c8bc06bc2f809d2fee6c801d2b34d21
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add tests for bad RCPT command syntax.


  Commit: 1efbd1289379863a5245a04bcb8740082aad4824
      https://github.com/dovecot/core/commit/1efbd1289379863a5245a04bcb8740082aad4824
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add tests for MAIL command workarounds.


  Commit: 921cd33c6812bcadfb7dbc5abbd29be76462078c
      https://github.com/dovecot/core/commit/921cd33c6812bcadfb7dbc5abbd29be76462078c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add tests for RCPT command workarounds.


  Commit: 7bad32c8aa23a084a38348d7e27891981fc737e1
      https://github.com/dovecot/core/commit/7bad32c8aa23a084a38348d7e27891981fc737e1
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M doc/example-config/conf.d/20-submission.conf
    M src/submission/submission-client.c
    M src/submission/submission-settings.c
    M src/submission/submission-settings.h

  Log Message:
  -----------
  submission: Add workarounds for well-known MAIL and RCPT command syntax deviations.

This adds a new `submission_client_workarounds' setting that works analogous to
the `imap_client_workarounds' setting.

Workarounds:

- whitespace-before-path: Allow one or more spaces or tabs between `MAIL FROM:'
                    and path and between `RCPT TO:' and path.
- mailbox-for-path:       Allow using bare Mailbox syntax (i.e., without <...>)
                    instead of full path syntax.


  Commit: 9002dc87fb9b468ec8675ad41f6d20d1b87889ee
      https://github.com/dovecot/core/commit/9002dc87fb9b468ec8675ad41f6d20d1b87889ee
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-27 (Fri, 27 Apr 2018)

  Changed paths:
    M src/lib-smtp/smtp-address.c

  Log Message:
  -----------
  lib-smtp: Fix empty address parsing

sret wasn't initialized, which could have randomly caused "Path only
consists of source route" error with empty addresses. Broken by
81c8955e3d1475c6ab1892b1d3edf91126683fda


Compare: https://github.com/dovecot/core/compare/2f86f050a62d...9002dc87fb9b