[dovecot/core] bdcd91: lib-index: Fix assert-crash with lock_method=dotlo...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: bdcd91c28c0f5269d8971b9f5ec5d68f7155492a
      https://github.com/dovecot/core/commit/bdcd91c28c0f5269d8971b9f5ec5d68f7155492a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-08 (Thu, 08 Feb 2018)

  Changed paths:
    M src/lib-index/mail-cache-private.h
    M src/lib-index/mail-cache.c

  Log Message:
  -----------
  lib-index: Fix assert-crash with lock_method=dotlock

The dotlock wasn't deleted in all code paths. Fix this by simplifying
the unlocking to be done the same way with and without dotlock.

Fixes:
Panic: file mail-cache.c: line 624 (mail_cache_lock_file): assertion failed: (cache->dotlock == NULL)