[dovecot/core] 4f9715: lib-smtp: server: Moved ssl_start argument from sm...

[GitHub]

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 4f9715726c899938909dc7ab7cccdceb9119d266
      https://github.com/dovecot/core/commit/4f9715726c899938909dc7ab7cccdceb9119d266
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.h
    M src/lib-smtp/test-smtp-payload.c
    M src/lib-smtp/test-smtp-server-errors.c
    M src/lmtp/client.c
    M src/submission-login/client.c
    M src/submission/submission-client.c

  Log Message:
  -----------
  lib-smtp: server: Moved ssl_start argument from smtp_server_connection_start() to smtp_server_connection_create().

This frees smtp_server_connection_start() for general use.


  Commit: 04676afabd5109ed5e4fe7583d3cf07c49227cad
      https://github.com/dovecot/core/commit/04676afabd5109ed5e4fe7583d3cf07c49227cad
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: Moved smtp_server_connection_start() after smtp_server_connection_login().

Also fixes an indent problem in the header comment implicitly.


  Commit: dbd3403847f7f8a16dab5738600e5074c7ee4505
      https://github.com/dovecot/core/commit/dbd3403847f7f8a16dab5738600e5074c7ee4505
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.h
    M src/submission/submission-client.c

  Log Message:
  -----------
  lib-smtp: server: Remove implicit smtp_server_connection_start() from smtp_server_connection_login().


  Commit: 67c804150a5d8f8c215d71600d8894d9ddaebf96
      https://github.com/dovecot/core/commit/67c804150a5d8f8c215d71600d8894d9ddaebf96
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Delay handling initial input (from login service) until after smtp_server_connection_start().

Instead, it is now handled in normal io callback.


  Commit: 2dc83a5a7edbe219e444312b6d9f705d2108eff8
      https://github.com/dovecot/core/commit/2dc83a5a7edbe219e444312b6d9f705d2108eff8
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server-private.h

  Log Message:
  -----------
  lib-smtp: server: Protect smpt_server_connection_start() from being called multiple times.


  Commit: 52bf7c543e0b853195a92f041973096d77f4059e
      https://github.com/dovecot/core/commit/52bf7c543e0b853195a92f041973096d77f4059e
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Prevent calling smtp_server_connection_login() after smtp_server_connection_start().

Added assertion.


  Commit: 8eb9c89541d84ce7e4598fa59cba1c60140fe8f2
      https://github.com/dovecot/core/commit/8eb9c89541d84ce7e4598fa59cba1c60140fe8f2
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server-private.h
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: Add APIs for halting and resuming connection command handling.

Also adds function to start the connection in a pending (halted) state. This way the greeting can already be sent (over SSL if needed), while deferring command handling until some external activity is completed.


  Commit: ffd0514cb93e57ea104a080b762487bd2b0f4ddf
      https://github.com/dovecot/core/commit/ffd0514cb93e57ea104a080b762487bd2b0f4ddf
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/submission/submission-client.c

  Log Message:
  -----------
  submission: Block server input handling until proxy connection to relay server completes.

This makes sure we are aware of the full extent of the backend server's capabilities, before we start handling commands.
Before, only EHLO commands were blocked this way, but this did not account for MAIL/RCPT parameters, which are equally dependent.
Fixes problems with clients that send no EHLO after AUTH, like Thunderbird.


  Commit: d5ed3c4f0815f67f27e4bf5a8b03f39e82e90bec
      https://github.com/dovecot/core/commit/d5ed3c4f0815f67f27e4bf5a8b03f39e82e90bec
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/submission/cmd-helo.c
    M src/submission/submission-client.h

  Log Message:
  -----------
  submission: EHLO command: Remove obsolete pending_ehlo handling.

This was used to wait with sending an EHLO reply until the proxy connection to the relay server completes.
The previous commit made this functionality obsolete, since command input handling is blocked entirely until the proxy connection is ready.


  Commit: 4517f63355c5e503adc25ab09b3c69118ac6fd8f
      https://github.com/dovecot/core/commit/4517f63355c5e503adc25ab09b3c69118ac6fd8f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-data.c

  Log Message:
  -----------
  lib-smtp: server: Fix assertion failure occurring for a second failed BDAT/BURL command.

Assertion was:

Panic: file smtp-server-cmd-data.c: line 420 (smtp_server_connection_data_chunk_init): assertion failed: (data_cmd->chunk_first)


Compare: https://github.com/dovecot/core/compare/20a8237da58d...4517f63355c5