[dovecot/core] 6b4960: lib: Add file_lock_from_dotlock()

Tue Feb 20 21:30:44 EET 2018

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 6b49608a2e861014c48ec745cd10197d95db70c9
      https://github.com/dovecot/core/commit/6b49608a2e861014c48ec745cd10197d95db70c9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib/file-lock.c
    M src/lib/file-lock.h

  Log Message:
  -----------
  lib: Add file_lock_from_dotlock()

The dotlock creation requires various settings, so the file-lock.h API can't
easily be used to create it. But once created, it's simpler to keep all lock
types in the same struct file_lock, which can be unlocked/freed once
finished.

  Commit: f3065275dab5635978d0014b91a599b9889cea3b
      https://github.com/dovecot/core/commit/f3065275dab5635978d0014b91a599b9889cea3b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: Add mail_storage_lock_create()

This is split off of mailbox_lock_file_create().

  Commit: e5b99149c8d12ac2fddd8f13e94c29e889de55f1
      https://github.com/dovecot/core/commit/e5b99149c8d12ac2fddd8f13e94c29e889de55f1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-storage/mail-user.c

  Log Message:
  -----------
  lib-storage: Change mail_user_lock_file_create() to use mail_storage_lock_create()

  Commit: 0deeb855513b2a59688da1c9aab1431408c24a36
      https://github.com/dovecot/core/commit/0deeb855513b2a59688da1c9aab1431408c24a36
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c
    M src/lib-storage/mail-user.c

  Log Message:
  -----------
  lib-storage: mail_storage_lock_create() - add support for dotlocks

  Commit: 3ce6458ceecc108cbfeefb06e2c5717ad7716e42
      https://github.com/dovecot/core/commit/3ce6458ceecc108cbfeefb06e2c5717ad7716e42
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: mailbox_rename() - Use source storage for errors

It was documented to use source storage for errors, but some of the errors
were set to destination storage.

  Commit: 1ccc5eb7fb1d18214aeb131328acd7293ec2dfd9
      https://github.com/dovecot/core/commit/1ccc5eb7fb1d18214aeb131328acd7293ec2dfd9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: mailbox_delete() - Fix cleanup in error handling

If removing index deletion mark failed, box->deleting wasn't set to FALSE
and the mailbox was left opened.

  Commit: 72b239b1658f00130f31dd84a0a9fcd13d74205d
      https://github.com/dovecot/core/commit/72b239b1658f00130f31dd84a0a9fcd13d74205d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-storage/mailbox-list-private.h
    M src/lib-storage/mailbox-list.c

  Log Message:
  -----------
  lib-storage: Add mailbox_list_[un]lock()

  Commit: 36c2a2f7ee9d346917327d1298b5aeae200658e0
      https://github.com/dovecot/core/commit/36c2a2f7ee9d346917327d1298b5aeae200658e0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: Lock mailbox_list for mailbox create/delete/rename

This is only required for mailbox creation to fix a race condition with
LAYOUT=index: If INBOX doesn't exist it will rescan the mailboxes to
find out if there are any missing ones. If INBOX creation isn't locked,
it's possible that the first process hasn't finished creating INBOX
before the second process find it and attempts to open it.

The delete and rename locking are probably useful to guard against race
conditions when clients intentionally issues create/delete/rename commands
concurrently.

  Commit: fbc2195f371dac8c5dad433d1b8f74a34ec2a4e2
      https://github.com/dovecot/core/commit/fbc2195f371dac8c5dad433d1b8f74a34ec2a4e2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-09 (Fri, 09 Feb 2018)

  Changed paths:
    M src/lib-index/mail-cache-private.h
    M src/lib-index/mail-cache.c

  Log Message:
  -----------
  lib-index: Fix assert-crash with lock_method=dotlock

The dotlock wasn't deleted in all code paths. Fix this by simplifying
the unlocking to be done the same way with and without dotlock.

Fixes:
Panic: file mail-cache.c: line 624 (mail_cache_lock_file): assertion failed: (cache->dotlock == NULL)

  Commit: 52d6f2db8292ad56d12b3af3611745b92738946e
      https://github.com/dovecot/core/commit/52d6f2db8292ad56d12b3af3611745b92738946e
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-12 (Mon, 12 Feb 2018)

  Changed paths:
    M src/lib/restrict-access.h

  Log Message:
  -----------
  lib: Clarify restrict_access_allow_coredumps

  Commit: 07e12663853d4ee9ada9cf5c91fb84a38fcbe1ce
      https://github.com/dovecot/core/commit/07e12663853d4ee9ada9cf5c91fb84a38fcbe1ce
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-12 (Mon, 12 Feb 2018)

  Changed paths:
    M src/lib/restrict-access.c
    M src/lib/restrict-access.h

  Log Message:
  -----------
  lib: Add restrict_access_get/set_dumpable

  Commit: 977a292de7080f891dcf7f3aae6d92441cddbc8a
      https://github.com/dovecot/core/commit/977a292de7080f891dcf7f3aae6d92441cddbc8a
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-12 (Mon, 12 Feb 2018)

  Changed paths:
    M src/plugins/old-stats/mail-stats-fill.c

  Log Message:
  -----------
  old-stats: Set process dumpable during stats gathering

/proc/self/io is not accessible otherwise

  Commit: ea2dbaa29028719a3f9599502ffe732cf73dc544
      https://github.com/dovecot/core/commit/ea2dbaa29028719a3f9599502ffe732cf73dc544
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-12 (Mon, 12 Feb 2018)

  Changed paths:
    M src/lib-storage/index/index-transaction.c
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: Set mailbox_transaction_context.flags earlier

Set it in index_transaction_init() so plugins' transaction_begin() methods
see it after calling super.transaction_begin().

  Commit: 0b2363a8997b4b413732fe86980c14b7eaf111ea
      https://github.com/dovecot/core/commit/0b2363a8997b4b413732fe86980c14b7eaf111ea
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-12 (Mon, 12 Feb 2018)

  Changed paths:
    M src/plugins/replication/replication-plugin.c

  Log Message:
  -----------
  replication: Don't send notification for changes done by dsync transactions

  Commit: b4e076dbaae559547151f230aa9756dc67997929
      https://github.com/dovecot/core/commit/b4e076dbaae559547151f230aa9756dc67997929
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-14 (Wed, 14 Feb 2018)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Fix IO after enabling SSL

io_add_istream() needs to be used with the SSL istream, otherwise it can
cause hangs.

  Commit: 186a3319e6564093a23e2f3fcca134bc742c44b5
      https://github.com/dovecot/core/commit/186a3319e6564093a23e2f3fcca134bc742c44b5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-14 (Wed, 14 Feb 2018)

  Changed paths:
    M src/doveadm/server-connection.c

  Log Message:
  -----------
  doveadm: client: Set IO only after enabling SSL

io_add_istream() needs to be used with the SSL istream, otherwise it can
cause hangs.

  Commit: 962e5953de2e60d51ff22172f40ca63ff3131438
      https://github.com/dovecot/core/commit/962e5953de2e60d51ff22172f40ca63ff3131438
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-14 (Wed, 14 Feb 2018)

  Changed paths:
    M src/lib/connection.c
    M src/lib/connection.h

  Log Message:
  -----------
  lib: Add connection_streams_changed()

Originally by Stephan Bosch

  Commit: 8bcd5e5cbe64ad874b7059c402ce86202ea0d318
      https://github.com/dovecot/core/commit/8bcd5e5cbe64ad874b7059c402ce86202ea0d318
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-14 (Wed, 14 Feb 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: Recreate connection IO after streams change

This fixes hangs after STARTTLS.

Originally by Stephan Bosch

  Commit: abf71b6ab2b04dc477372ddc78f7be001009de70
      https://github.com/dovecot/core/commit/abf71b6ab2b04dc477372ddc78f7be001009de70
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-14 (Wed, 14 Feb 2018)

  Changed paths:
    M src/lib/istream-private.h
    M src/lib/istream.c

  Log Message:
  -----------
  lib: Add i_stream_get_root_io() and use it to deduplicate code

  Commit: 4bbad8a8aea295dc6cc551d00e4bb40b51fba24f
      https://github.com/dovecot/core/commit/4bbad8a8aea295dc6cc551d00e4bb40b51fba24f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-14 (Wed, 14 Feb 2018)

  Changed paths:
    M src/lib-ssl-iostream/iostream-openssl.c

  Log Message:
  -----------
  lib-ssl-iostream: Assert-crash if input stream has IO already set

  Commit: e0b3e89dcc8e7c8a3ea4be8f58e426a218d53b61
      https://github.com/dovecot/core/commit/e0b3e89dcc8e7c8a3ea4be8f58e426a218d53b61
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-15 (Thu, 15 Feb 2018)

  Changed paths:
    M src/auth/auth-policy.c
    M src/auth/auth-settings.c

  Log Message:
  -----------
  auth: Use correct username is auth policy requests

When doing master authentication as first, use
the username of the user, not master user, for policy lookup.

  Commit: d3a3654dcf2eae7964cfb47f2738b6b551466735
      https://github.com/dovecot/core/commit/d3a3654dcf2eae7964cfb47f2738b6b551466735
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-15 (Thu, 15 Feb 2018)

  Changed paths:
    M src/auth/auth-request-handler.c
    M src/auth/auth-request.c
    M src/auth/auth-settings.c
    M src/auth/auth-settings.h

  Log Message:
  -----------
  auth: Add policy check configuration options

Allows disabling before/after auth checks, or reporting.

  Commit: e15a37fdae4ece818119833cc73868ad42b733eb
      https://github.com/dovecot/core/commit/e15a37fdae4ece818119833cc73868ad42b733eb
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-15 (Thu, 15 Feb 2018)

  Changed paths:
    M src/auth/auth-request.c

  Log Message:
  -----------
  auth: Set correct context type when bypassing reporting in auth_success

Broken in 41ff6e6a4a085786d4c15a58c7c50a28e2110c3f

  Commit: e0285e56f9d76569693c7641629ce1a2deaafd5f
      https://github.com/dovecot/core/commit/e0285e56f9d76569693c7641629ce1a2deaafd5f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-15 (Thu, 15 Feb 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: client: Fix ignoring invalid certificate from server.

Although it initially allowed the invalid certificate, it would still fail later
on while reading/writing the SSL streams.

  Commit: abc7aab27a89677ec66f718c14a76f372726903a
      https://github.com/dovecot/core/commit/abc7aab27a89677ec66f718c14a76f372726903a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-15 (Thu, 15 Feb 2018)

  Changed paths:
    M src/lmtp/lmtp-local.c

  Log Message:
  -----------
  lmtp: local: Fix segfault occurring when quota is exceeded.

  Commit: a2c36f57afa453c3f0c02e714199e9bbaee38482
      https://github.com/dovecot/core/commit/a2c36f57afa453c3f0c02e714199e9bbaee38482
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-15 (Thu, 15 Feb 2018)

  Changed paths:
    M src/lmtp/lmtp-local.c

  Log Message:
  -----------
  lmtp: local: Make local variable for rcpt->rcpt.rcpt_cmd in lmtp_local_rcpt_check_quota().

  Commit: c81bd718b14bac70c70e25504246212643e37072
      https://github.com/dovecot/core/commit/c81bd718b14bac70c70e25504246212643e37072
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-15 (Thu, 15 Feb 2018)

  Changed paths:
    M src/lmtp/lmtp-local.c

  Log Message:
  -----------
  lmtp: local: Add explicit cmd parameter to lmtp_local_rcpt_reply_overquota().

Using the RCPT cmd is only valid for the RCPT command and not when quota excess
is detected during DATA. That would cause a segmentation fault, since
rcpt->rcpt.rcpt_cmd == NULL.

  Commit: 254cae66e7bd6dd5ab825d8f172c1fdad42129ca
      https://github.com/dovecot/core/commit/254cae66e7bd6dd5ab825d8f172c1fdad42129ca
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-15 (Thu, 15 Feb 2018)

  Changed paths:
    M src/lmtp/lmtp-local.c

  Log Message:
  -----------
  lmtp: local: Use recipient index in lmtp_local_rcpt_reply_overquota().

When used during the DATA command, it should send a reply for the correct
recipient. During the RCPT command there is only one reply due. Added assert
that checks this.

  Commit: 6791b1e856b11bab703efffe6c3e022ac050f2f5
      https://github.com/dovecot/core/commit/6791b1e856b11bab703efffe6c3e022ac050f2f5
  Author: Hideo Yoshizane <hideo.yoshizane at open-xchange.com>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M configure.ac
    M src/plugins/Makefile.am
    A src/plugins/charset-alias/Makefile.am
    A src/plugins/charset-alias/charset-alias-plugin.c
    A src/plugins/charset-alias/charset-alias-plugin.h

  Log Message:
  -----------
  charset-alias-plugin

  Commit: c2a0b61700ba9439a6a0a1b644b4ea7c5b37c7b4
      https://github.com/dovecot/core/commit/c2a0b61700ba9439a6a0a1b644b4ea7c5b37c7b4
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/plugins/Makefile.am
    M src/plugins/charset-alias/Makefile.am
    M src/plugins/charset-alias/charset-alias-plugin.c
    M src/plugins/charset-alias/charset-alias-plugin.h

  Log Message:
  -----------
  charset-alias: Cleanup whitespace

Remove \r from end of lines and remove trailing whitespace.

  Commit: 96d1d2d8dbda5108c957d36efadacf179db293ec
      https://github.com/dovecot/core/commit/96d1d2d8dbda5108c957d36efadacf179db293ec
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/plugins/charset-alias/charset-alias-plugin.c

  Log Message:
  -----------
  charset-alias: Fix keyvalues iteration

charset-alias-plugin.c:113:27: error: comparison between pointer and zero
character constant [-Werror=pointer-compare]
  for (i = 0; keyvalues[i] != '\0'; i++) {
                     ^~
charset-alias-plugin.c:113:14: note: did you mean to dereference the pointer?
  for (i = 0; keyvalues[i] != '\0'; i++) {

  Commit: bb80752f85eb7371c497133857fb7e2d1dac6b83
      https://github.com/dovecot/core/commit/bb80752f85eb7371c497133857fb7e2d1dac6b83
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/imap/imap-fetch-body.c

  Log Message:
  -----------
  imap: Add parenthesis to FETCH SNIPPET (FUZZY text) response

Otherwise it violates the RFC 3501 text about FETCH responses.

  Commit: 2f816572826167ab50284f26a560f8674f697d5b
      https://github.com/dovecot/core/commit/2f816572826167ab50284f26a560f8674f697d5b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/imap/imap-fetch-body.c

  Log Message:
  -----------
  imap: Don't enforce sending SNIPPET reply as literal

Also change it to use "cur_str" since the reply is never very long.

  Commit: 9e1a3a76dd3a29569a2e19477d2235fecc2a564c
      https://github.com/dovecot/core/commit/9e1a3a76dd3a29569a2e19477d2235fecc2a564c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/imap/imap-fetch-body.c

  Log Message:
  -----------
  imap: Fix FETCH SNIPPET

1) _BUFFERED flag wasn't set, which caused a missing space before the "SNIPPET".
2) It caused \Seen flag to be added to the mail

  Commit: 0de79059666ec73e12edcd6767f78bce5dafd5fd
      https://github.com/dovecot/core/commit/0de79059666ec73e12edcd6767f78bce5dafd5fd
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/imap/imap-fetch-body.c

  Log Message:
  -----------
  imap: If snippet is not available return NIL

  Commit: d9a1a7cbec19f4c6a47add47688351f8c3a0e372
      https://github.com/dovecot/core/commit/d9a1a7cbec19f4c6a47add47688351f8c3a0e372
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/lib-ssl-iostream/iostream-openssl-context.c

  Log Message:
  -----------
  lib-ssl-iostream: Use SSL_CTX_set_ecdh_auto macro

This macro is same for 1.0.2 and 1.1.0 and libressl.

  Commit: a8bd6c9e9e797e442e0ad21837cdcc788361e293
      https://github.com/dovecot/core/commit/a8bd6c9e9e797e442e0ad21837cdcc788361e293
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index.c

  Log Message:
  -----------
  lib-storage: mailbox_list_index_handle_corruption() - Move actual handling to its own function

  Commit: a82c0f03069ce3165d05754b639a18c617218180
      https://github.com/dovecot/core/commit/a82c0f03069ce3165d05754b639a18c617218180
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index.c

  Log Message:
  -----------
  lib-storage: mailbox_list_index_handle_corruption() - Lock mailbox list while rebuilding

This guards against simultaneous mailbox create/delete/rename.

  Commit: 9a2898fb8db2e0e125114ae708b9ef7e13e97e50
      https://github.com/dovecot/core/commit/9a2898fb8db2e0e125114ae708b9ef7e13e97e50
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index.c

  Log Message:
  -----------
  lib-storage: Unless LAYOUT=index, don't rebuild list index on missing INBOX

  Commit: f7d20995cec6737e3c4861f203ec7d13b02da3aa
      https://github.com/dovecot/core/commit/f7d20995cec6737e3c4861f203ec7d13b02da3aa
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/lib-program-client/program-client-local.c

  Log Message:
  -----------
  lib-program-client: Remove extra drop_setuid_root flag copy

  Commit: aeddc84b663d0b72970091a972db6c0442918694
      https://github.com/dovecot/core/commit/aeddc84b663d0b72970091a972db6c0442918694
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/lib-storage/mail-storage-service.c
    M src/lib/restrict-access.c
    M src/lib/restrict-access.h

  Log Message:
  -----------
  lib: Flip drop_setuid_root in restrict_access_settings

  Commit: f6a3f3eb8bdd825e362578ebdc8ac82abd178d55
      https://github.com/dovecot/core/commit/f6a3f3eb8bdd825e362578ebdc8ac82abd178d55
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/anvil/main.c
    M src/auth/main.c
    M src/config/main.c
    M src/dict/main.c
    M src/director/main.c
    M src/dns/dns-client.c
    M src/doveadm/main.c
    M src/imap-hibernate/main.c
    M src/indexer/indexer-worker.c
    M src/indexer/indexer.c
    M src/ipc/main.c
    M src/lib-program-client/program-client-local.c
    M src/lib-storage/mail-storage-service.c
    M src/lib/restrict-access.c
    M src/lib/restrict-access.h
    M src/lmtp/main.c
    M src/log/main.c
    M src/login-common/main.c
    M src/master/service-process.c
    M src/old-stats/main.c
    M src/plugins/quota/quota-status.c
    M src/replication/aggregator/aggregator.c
    M src/replication/replicator/replicator.c
    M src/stats/main.c
    M src/util/rawlog.c
    M src/util/script-login.c
    M src/util/script.c
    M src/util/tcpwrap.c

  Log Message:
  -----------
  lib: Add restrict_access_flags enum to use with restrict_access[_by_env]()

Swap parameter locations in the functions to make sure plugins are
updated to use the new api.

  Commit: 63ef0675599d9a0cbac9e90e878f488506bddc76
      https://github.com/dovecot/core/commit/63ef0675599d9a0cbac9e90e878f488506bddc76
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/master/service-process.c

  Log Message:
  -----------
  master: Flip disallow_root in drop_privileges()

  Commit: 9057b2f75beda3e4658b64f98b117e02180e8037
      https://github.com/dovecot/core/commit/9057b2f75beda3e4658b64f98b117e02180e8037
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/lib-storage/mail-storage-service.c

  Log Message:
  -----------
  lib-storage: Flip disallow_root in service_drop_privileges()

  Commit: a9eca13a1ccd1046ba92bb05e743c3fe18ee1cb2
      https://github.com/dovecot/core/commit/a9eca13a1ccd1046ba92bb05e743c3fe18ee1cb2
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/imap-urlauth/imap-urlauth-worker.c
    M src/imap/main.c
    M src/indexer/indexer-worker.c
    M src/lda/main.c
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-storage-service.h
    M src/lmtp/main.c
    M src/plugins/quota/quota-status.c
    M src/pop3/main.c
    M src/submission/main.c
    M src/util/script-login.c

  Log Message:
  -----------
  global: Flip MAIL_STORAGE_SERVICE_FLAG_DISALLOW_ROOT to ..._ALLOW_ROOT

  Commit: 084a6f8e6f7e41275530b56c01491374a98315e9
      https://github.com/dovecot/core/commit/084a6f8e6f7e41275530b56c01491374a98315e9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/imap/main.c

  Log Message:
  -----------
  imap: When running standalone, delay initializing namespaces until PREAUTH is sent

Most importantly this makes the code paths similar for standalone and
non-standalone clients, which is needed by the following commits.

  Commit: 4cf9cf959ae3bfe7a0ed91927c4c7919a7c09b76
      https://github.com/dovecot/core/commit/4cf9cf959ae3bfe7a0ed91927c4c7919a7c09b76
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/imap/imap-client.c
    M src/imap/imap-client.h
    M src/imap/imap-master-client.c
    M src/imap/main.c

  Log Message:
  -----------
  imap: Add client_create_finish() to finish namespace creation.

  Commit: f30a85a719ee5945f589d5e27fb5bc4e6b126899
      https://github.com/dovecot/core/commit/f30a85a719ee5945f589d5e27fb5bc4e6b126899
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/imap/imap-client.c

  Log Message:
  -----------
  imap: Don't set storage callbacks before namespaces are created

This fixes sending untagged OK/NO notifications from storage (e.g. lock
waits/override notifications). It was broken by
e031d9aaae59a9f79710dc1138b76b69272615a3

  Commit: 424753d9ddb5214bd2f74201f1bcc2b858bab626
      https://github.com/dovecot/core/commit/424753d9ddb5214bd2f74201f1bcc2b858bab626
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/doveadm/doveadm-dump-index.c

  Log Message:
  -----------
  doveadm dump: Show body.snippet in human-readable form

  Commit: 994ecfe787494bfc861ffc54be4302de75942737
      https://github.com/dovecot/core/commit/994ecfe787494bfc861ffc54be4302de75942737
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-storage/index/index-mail.c

  Log Message:
  -----------
  lib-storage: move snippet generation to mail-save-finish

This is necessary because some storage backends (most notably sdbox) do
not allow getting the mail stream before the mail is fully written out.
(See written_to_disk in sdbox-file.h.)

If we could avoid getting the stream to generate a snippet we could
leave this where it is.

  Commit: a1e1240aab2048c4b360090faa12dbb1869e88cc
      https://github.com/dovecot/core/commit/a1e1240aab2048c4b360090faa12dbb1869e88cc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-storage/index/index-mail.c
    M src/lib-storage/index/index-mail.h

  Log Message:
  -----------
  lib-storage: Make index_mail_want_cache() global

  Commit: 4d90f3fb2bee5afcc5c326c3f78b9556e9936252
      https://github.com/dovecot/core/commit/4d90f3fb2bee5afcc5c326c3f78b9556e9936252
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-storage/index/index-mail-headers.c

  Log Message:
  -----------
  lib-storage: Generate snippet while saving new mails

  Commit: bf055b4cb39d7ffa06fb650a3f771b2fa45bc873
      https://github.com/dovecot/core/commit/bf055b4cb39d7ffa06fb650a3f771b2fa45bc873
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib/module-context.h

  Log Message:
  -----------
  lib: Add MODULE_CONTEXT_REQUIRE

This will panic instead of return NULL. Should satisfy static
analyzers when used.

  Commit: 04bdefa1abac9a063022211761df664ecfa59950
      https://github.com/dovecot/core/commit/04bdefa1abac9a063022211761df664ecfa59950
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Require context in mail-deliver

Satisfies static analyzers

  Commit: 4adaae0c7ad5175bdf69921d078f3de3e8dcdc3a
      https://github.com/dovecot/core/commit/4adaae0c7ad5175bdf69921d078f3de3e8dcdc3a
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-storage/index/index-storage.h

  Log Message:
  -----------
  lib-storage: INDEX_STORAGE_CONTEXT now requires context

Satisfies static analyzers

  Commit: 1fad1b8c311b1c18b961f4b62eeec1a6c8b2eda7
      https://github.com/dovecot/core/commit/1fad1b8c311b1c18b961f4b62eeec1a6c8b2eda7
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index-storage.h

  Log Message:
  -----------
  lib-storage: INDEX_LIST_STORAGE_CONTEXT now requires context

Satisfies static analyzers

  Commit: f553314acfc57561c918cd9c6c17eb4258ef3908
      https://github.com/dovecot/core/commit/f553314acfc57561c918cd9c6c17eb4258ef3908
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-storage/index/mbox/mbox-storage.c

  Log Message:
  -----------
  lib-storage: MBOX_LIST_CONTEXT now requires context

Satisfies static analyzers

  Commit: 42f95f63b2e7f75b9d09c7e07aefffbae995a588
      https://github.com/dovecot/core/commit/42f95f63b2e7f75b9d09c7e07aefffbae995a588
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-sql/sql-db-cache.c

  Log Message:
  -----------
  lib-sql: SQL_DB_CACHE_CONTEXT now requires context

Satisfies static analyzers

  Commit: 6b49867028140d33ab690f04ebe5451bc20195b6
      https://github.com/dovecot/core/commit/6b49867028140d33ab690f04ebe5451bc20195b6
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/imap-old-stats/imap-stats-plugin.c

  Log Message:
  -----------
  imap-old-stats-plugins: Check suser for NULL

Satisfies static analyzers

  Commit: fa4ab393709d077f224c6168856a3fce73907fdf
      https://github.com/dovecot/core/commit/fa4ab393709d077f224c6168856a3fce73907fdf
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/replication/replication-plugin.c

  Log Message:
  -----------
  replication: Check ruser for NULL

Satisfies static analyzers

  Commit: d5975daef9347f02973f2218e08c48c3e9e5abc4
      https://github.com/dovecot/core/commit/d5975daef9347f02973f2218e08c48c3e9e5abc4
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/acl/acl-attributes.c
    M src/plugins/acl/acl-backend-vfile-acllist.c
    M src/plugins/acl/acl-lookup-dict.c
    M src/plugins/acl/acl-mailbox-list.c
    M src/plugins/acl/acl-mailbox.c
    M src/plugins/acl/acl-plugin.h
    M src/plugins/acl/acl-shared-storage.c
    M src/plugins/acl/acl-storage.c

  Log Message:
  -----------
  acl: Contexts are now required or checked

Satisfies static analyzers

  Commit: e16d51458e682145ccedd3ece509d848b031e82d
      https://github.com/dovecot/core/commit/e16d51458e682145ccedd3ece509d848b031e82d
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/trash/trash-plugin.c

  Log Message:
  -----------
  trash: Ensure quser is not NULL

Satisfies static analyzers

  Commit: 1e9fdc8bb9eecd16b08cc29370afd3eb36f8a1c5
      https://github.com/dovecot/core/commit/1e9fdc8bb9eecd16b08cc29370afd3eb36f8a1c5
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/expire/expire-plugin.c

  Log Message:
  -----------
  expire: Contexts are now required or checked

Satisfied static analyzers

  Commit: 5f6be61dd3376af4fb200436c7b7f804c50d4602
      https://github.com/dovecot/core/commit/5f6be61dd3376af4fb200436c7b7f804c50d4602
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/snarf/snarf-plugin.c

  Log Message:
  -----------
  snarf: Contexts are now required or checked

Satisfies static analyzers

  Commit: a9c19bb9149afc315a0fdccd97336cc40c2f5e8f
      https://github.com/dovecot/core/commit/a9c19bb9149afc315a0fdccd97336cc40c2f5e8f
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/snarf/snarf-plugin.c

  Log Message:
  -----------
  snarf: If sstorage is NULL, do not allocate box

Old code would continue if sstorage was NULL.

Found by static analyzer

  Commit: 18e78d322382464dc8179e51a29d4e914c69b448
      https://github.com/dovecot/core/commit/18e78d322382464dc8179e51a29d4e914c69b448
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/fts/fts-parser-script.c
    M src/plugins/fts/fts-storage.c
    M src/plugins/fts/fts-user.c

  Log Message:
  -----------
  fts: Contexts are now required or checked

Satisfied static analyzer

  Commit: fc4557f7f5b5f8e90f67201276e37b16b363777a
      https://github.com/dovecot/core/commit/fc4557f7f5b5f8e90f67201276e37b16b363777a
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/lazy-expunge/lazy-expunge-plugin.c

  Log Message:
  -----------
  lazy-expunge: Contexts are now required or checked

Satisfied static analyzers

  Commit: 86c945529f9a7f54a1b38eb96e0ea959115a172a
      https://github.com/dovecot/core/commit/86c945529f9a7f54a1b38eb96e0ea959115a172a
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/apparmor/apparmor-plugin.c

  Log Message:
  -----------
  apparmor: Ensure auser is not NULL

Satisfies static analyzers

  Commit: 3c18b2025ef12296a280a34bde63652cf8333a1a
      https://github.com/dovecot/core/commit/3c18b2025ef12296a280a34bde63652cf8333a1a
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/quota/quota-storage.c

  Log Message:
  -----------
  quota: Contexts are now required or checked

Satisfied static analyzers

  Commit: c0ffd5259afb74a285bc84d6c79fe20f869a77da
      https://github.com/dovecot/core/commit/c0ffd5259afb74a285bc84d6c79fe20f869a77da
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/pop3-migration/pop3-migration-plugin.c

  Log Message:
  -----------
  pop3-migration: Contexts are now required or checked

Satisfies static analyzers

  Commit: 0333ab0d6b6f008d3a36acfc4e9758bbb1846725
      https://github.com/dovecot/core/commit/0333ab0d6b6f008d3a36acfc4e9758bbb1846725
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/notify/notify-storage.c

  Log Message:
  -----------
  notify: Contexts are now required or checked

Satisfied static analyzers

  Commit: 9cc36d00c8b0264afd662ae19248051d29ee7052
      https://github.com/dovecot/core/commit/9cc36d00c8b0264afd662ae19248051d29ee7052
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/mail-filter/mail-filter-plugin.c

  Log Message:
  -----------
  mail-filter: Contexts are now required or checked

Satisfies static analyzers

  Commit: f96ddb379cd2c5a44c2b49c8173bff9d7a302570
      https://github.com/dovecot/core/commit/f96ddb379cd2c5a44c2b49c8173bff9d7a302570
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/mailbox-alias/mailbox-alias-plugin.c

  Log Message:
  -----------
  mailbox-alias: Contexts are now required or checked

Satisfies static analyzers

  Commit: f81b6623c31af71ab7ae1628ffc308dce84a3df6
      https://github.com/dovecot/core/commit/f81b6623c31af71ab7ae1628ffc308dce84a3df6
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/zlib/zlib-plugin.c

  Log Message:
  -----------
  zlib: Contexts are now required or checked

Satisfies static analyzers

  Commit: afba4cf1002ee2153e796ffd73509af1e9f634f9
      https://github.com/dovecot/core/commit/afba4cf1002ee2153e796ffd73509af1e9f634f9
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/quota-clone/quota-clone-plugin.c

  Log Message:
  -----------
  quota-clone: Contexts are now required or checked

Satisfies static analyzers

  Commit: 4efb529edc72a822781f8646e64898e4448863a4
      https://github.com/dovecot/core/commit/4efb529edc72a822781f8646e64898e4448863a4
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/old-stats/mail-stats-connection.c
    M src/plugins/old-stats/stats-plugin.c
    M src/plugins/old-stats/stats-plugin.h

  Log Message:
  -----------
  old-stats: Contexts are now required or checked

Satisfies static analyzers

  Commit: 19b6330127b559490a1deb80ed54dae6cfa3ddce
      https://github.com/dovecot/core/commit/19b6330127b559490a1deb80ed54dae6cfa3ddce
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/mail-crypt/mail-crypt-acl-plugin.c
    M src/plugins/mail-crypt/mail-crypt-plugin.c

  Log Message:
  -----------
  mail-crypt: Contexts are now required or checked

Satisfies static analyzers

  Commit: bdf19e15b9577b9193873e5776de8060f6fc0528
      https://github.com/dovecot/core/commit/bdf19e15b9577b9193873e5776de8060f6fc0528
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/last-login/last-login-plugin.c

  Log Message:
  -----------
  last-login: Contexts are now required or checked

Satisfies static analyzers

  Commit: 6ff57044c350677eb9e582892de726fd01cc6314
      https://github.com/dovecot/core/commit/6ff57044c350677eb9e582892de726fd01cc6314
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/pop3-migration/pop3-migration-plugin.c

  Log Message:
  -----------
  pop3-migration-plugin: Fix context requirements

Fixes Panic: Module context pop3_migration_storage_module missing

Broken by a8703ce24540b7efaa51a8c7d3c72e72727f9789

  Commit: 511fba2e5821c67be525403598ad18c61f33a2a1
      https://github.com/dovecot/core/commit/511fba2e5821c67be525403598ad18c61f33a2a1
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/old-stats/stats-plugin.c

  Log Message:
  -----------
  old-stats-plugin: Fix context requirements

Fixes Panic: Module context stats_storage_module missing

Broken by 6afdf0b6fce26c5492d5e56f6f16fb8a4d869566

  Commit: 8fc876d9ec299bceaf1cab8e3cc7e6444487d72f
      https://github.com/dovecot/core/commit/8fc876d9ec299bceaf1cab8e3cc7e6444487d72f
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/mail-log/mail-log-plugin.c

  Log Message:
  -----------
  mail-log: Contexts are now required or checked

Satisfies static analyzers

  Commit: 37aed1ab5db8070ef15c182001f42bf4e3f2b83f
      https://github.com/dovecot/core/commit/37aed1ab5db8070ef15c182001f42bf4e3f2b83f
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index-backend.c
    M src/lib-storage/list/mailbox-list-index-iter.c
    M src/lib-storage/list/mailbox-list-index-notify.c
    M src/lib-storage/list/mailbox-list-index-status.c
    M src/lib-storage/list/mailbox-list-index-sync.c
    M src/lib-storage/list/mailbox-list-index.c
    M src/lib-storage/list/mailbox-list-index.h
    M src/lib-storage/list/mailbox-list-notify-tree.c

  Log Message:
  -----------
  lib-storage: Add and use INDEX_LIST_CONTEXT_REQUIRE

Satisfies static analyzers

  Commit: 850a34d957d3a68c81f57e7b684c19ef6b8d8021
      https://github.com/dovecot/core/commit/850a34d957d3a68c81f57e7b684c19ef6b8d8021
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-index/mail-cache-transaction.c

  Log Message:
  -----------
  lib-index: Add and use CACHE_TRANS_CONTEXT_REQUIRE

Satisfies static analyzers

  Commit: f6a72b464c3d6918200a87d823cdfd7c88861380
      https://github.com/dovecot/core/commit/f6a72b464c3d6918200a87d823cdfd7c88861380
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-storage/index/index-thread.c

  Log Message:
  -----------
  lib-storage: Add and use MAIL_THREAD_CONTEXT_REQUIRE

Satisfies static analyzers

  Commit: 603cac0df63769053d32616c64c673f0405101c4
      https://github.com/dovecot/core/commit/603cac0df63769053d32616c64c673f0405101c4
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-storage/index/index-transaction.c
    M src/lib-storage/mail-storage-private.h

  Log Message:
  -----------
  lib-storage: Add and use MAIL_STORAGE_CONTEXT_REQUIRE

Satisfies static analyzers

  Commit: 75f6ed7d05fe1f9ef32023a5a1e10e555e14f5f0
      https://github.com/dovecot/core/commit/75f6ed7d05fe1f9ef32023a5a1e10e555e14f5f0
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-search.c

  Log Message:
  -----------
  lib-storage: imapc - Ensure search ctx is not NULL

Satisfies static analyzers

  Commit: 86f3bd9396431f1cdd1fc9b4fe5fb9601868bf10
      https://github.com/dovecot/core/commit/86f3bd9396431f1cdd1fc9b4fe5fb9601868bf10
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/acl/acl-mailbox-list.c
    M src/plugins/acl/acl-mailbox.c
    M src/plugins/acl/acl-plugin.h

  Log Message:
  -----------
  acl: Add and use ACL_LIST_CONTEXT_REQUIRE

Satisfies static analyzers

  Commit: 7536e28ad30d8a2aeb23ad562a13b9a8a33a0520
      https://github.com/dovecot/core/commit/7536e28ad30d8a2aeb23ad562a13b9a8a33a0520
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/acl/acl-mailbox-list.c
    M src/plugins/acl/acl-plugin.h
    M src/plugins/acl/doveadm-acl.c

  Log Message:
  -----------
  acl: Add and use ACL_USER_CONTEXT_REQUIRE

Satisfies static analyzers

  Commit: 11133c3ed62c082a4325bd91ec0e59f007dd97d1
      https://github.com/dovecot/core/commit/11133c3ed62c082a4325bd91ec0e59f007dd97d1
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/acl/acl-mailbox.c

  Log Message:
  -----------
  acl: Fix ACL_CONTEXT check

Was incorrect in 3131b3878de3245db7552234e66d437e8fde9351

  Commit: 358b6630deca0356dc1cebb33fa4e3bc9b0fedcf
      https://github.com/dovecot/core/commit/358b6630deca0356dc1cebb33fa4e3bc9b0fedcf
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/fts-solr/fts-backend-solr-old.c
    M src/plugins/fts-solr/fts-solr-plugin.c
    M src/plugins/fts-solr/fts-solr-plugin.h

  Log Message:
  -----------
  fts-solr: Add and use FTS_SOLR_USER_CONTEXT_REQUIRE

Satisfies static analyzers

  Commit: cc90fd9cad7a00be6f8df16640ea43f860f69220
      https://github.com/dovecot/core/commit/cc90fd9cad7a00be6f8df16640ea43f860f69220
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/mail-crypt/mail-crypt-plugin.c

  Log Message:
  -----------
  mail-crypt: Add and use MAIL_CRYPT_USER_CONTEXT_REQUIRE

Satisfies static analyzers

  Commit: ae5c5eaf93f3eec0482998bef6821fb1c6bee74c
      https://github.com/dovecot/core/commit/ae5c5eaf93f3eec0482998bef6821fb1c6bee74c
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/lazy-expunge/lazy-expunge-plugin.c

  Log Message:
  -----------
  lazy-expunge: Fix context checking

Was not done properly in 462a3d92adcde4bfa9a575875bd8ae740b89ce9e

  Commit: 019febbd43f5c91f850440d1d60fe38afe09908c
      https://github.com/dovecot/core/commit/019febbd43f5c91f850440d1d60fe38afe09908c
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/imap-zlib/imap-zlib-plugin.c

  Log Message:
  -----------
  imap-zlib: Context is now required

Satisfies static analyzers

  Commit: fe1ec4bcdc5f930270d5f3424f77499e0deccb4b
      https://github.com/dovecot/core/commit/fe1ec4bcdc5f930270d5f3424f77499e0deccb4b
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/quota/quota-plugin.h
    M src/plugins/quota/quota-storage.c

  Log Message:
  -----------
  quota: Add and use QUOTA_USER_CONTEXT_REQUIRE

Satisfies static analyzers

  Commit: b230128c7b34ecc3614ee73f7f2e142017a96a77
      https://github.com/dovecot/core/commit/b230128c7b34ecc3614ee73f7f2e142017a96a77
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/virtual/virtual-search.c
    M src/plugins/virtual/virtual-storage.c
    M src/plugins/virtual/virtual-storage.h

  Log Message:
  -----------
  virtual: Contexts are now required or checked

Satisfies static analyzers

  Commit: 3ae3e7f92c1f6d3610ebaeb409e23b27b9476c07
      https://github.com/dovecot/core/commit/3ae3e7f92c1f6d3610ebaeb409e23b27b9476c07
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/expire/doveadm-expire.c

  Log Message:
  -----------
  expire: DOVEADM_EXPIRE_MAIL_CMD_CONTEXT is now required

Satisfied static analyzers

  Commit: 595bb8680a8464e31fe09a721a83e3c16c2861ad
      https://github.com/dovecot/core/commit/595bb8680a8464e31fe09a721a83e3c16c2861ad
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/welcome/welcome-plugin.c

  Log Message:
  -----------
  welcome: WELCOME_CONTEXT is now required

Satisfies static analyzers

  Commit: 76f93fb0e8333bd0fc51847f3aa7b3dd66ce6d4d
      https://github.com/dovecot/core/commit/76f93fb0e8333bd0fc51847f3aa7b3dd66ce6d4d
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/fts-lucene/fts-backend-lucene.c
    M src/plugins/fts-lucene/fts-lucene-plugin.c
    M src/plugins/fts-lucene/fts-lucene-plugin.h

  Log Message:
  -----------
  fts-lucene: Add and use FTS_LUCENE_USER_CONTEXT_REQUIRE

Satisfies static analyzers

  Commit: 74ef8506dcb946acc42722683e49fdcb964eed19
      https://github.com/dovecot/core/commit/74ef8506dcb946acc42722683e49fdcb964eed19
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/plugins/push-notification/push-notification-plugin.c

  Log Message:
  -----------
  push-notification: PUSH_NOTIFICATION_USER_CONTEXT is now required

Satisfies static analyzers

  Commit: 1c3b6f9221dc2a5270fe691bb625d0630196508e
      https://github.com/dovecot/core/commit/1c3b6f9221dc2a5270fe691bb625d0630196508e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-02-20 (Tue, 20 Feb 2018)

  Changed paths:
    M src/login-common/client-common.c

  Log Message:
  -----------
  *-login: Fix clients linked list corruption with SSL connections

This could have resulted in infinite loops or some of the clients being
skipped for some operations.

Compare: https://github.com/dovecot/core/compare/4517f63355c5...1c3b6f9221dc