[dovecot/pigeonhole] 807394: lib-sieve: imap4flags extension: Fix binary corrup...

[GitHub]

  Branch: refs/heads/master-0.5
  Home:   https://github.com/dovecot/pigeonhole
  Commit: 807394b44bb00e07f00158e9bd743fa215f3e81d
      https://github.com/dovecot/pigeonhole/commit/807394b44bb00e07f00158e9bd743fa215f3e81d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-04 (Thu, 04 Jan 2018)

  Changed paths:
    M src/lib-sieve/plugins/imap4flags/cmd-flag.c
    M src/lib-sieve/plugins/imap4flags/ext-imap4flags.c

  Log Message:
  -----------
  lib-sieve: imap4flags extension: Fix binary corruption occurring when setflag/addflag/removeflag flag-list is a variable.

The original implementation checked the first operand for being a variable.
Obviously, when the assigned flag string is just a variable, this doesn't work.
This causes the flag list to be recognized erroneously as a variable flags
string. Fixed the problem by explicitly emitting an omitted operand when there
is no second argument for a setflag/addflag/removeflag.

Because the new byte code format is incompatible, the extension version is
bumped to 1.


  Commit: 7e44fdd1edd2cf79e573c685a672e0807a96b641
      https://github.com/dovecot/pigeonhole/commit/7e44fdd1edd2cf79e573c685a672e0807a96b641
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-04 (Thu, 04 Jan 2018)

  Changed paths:
    M tests/extensions/imap4flags/basic.svtest

  Log Message:
  -----------
  tests: imap4flags extension: Added more tests involving variables.


Compare: https://github.com/dovecot/pigeonhole/compare/c9f2afe03771...7e44fdd1edd2