[dovecot/core] 94d999: lib-smtp: server: DATA command: Restore input hand...

Mon May 28 10:00:14 EEST 2018

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 94d99972a53f572be958debaaaa05f2e26df7955
      https://github.com/dovecot/core/commit/94d99972a53f572be958debaaaa05f2e26df7955
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-data.c

  Log Message:
  -----------
  lib-smtp: server: DATA command: Restore input handling upon failure.

Fixes command hanging upon failure during data transfer.

  Commit: 18d4bda11663bfdf8c06a39ff505dace77e134b8
      https://github.com/dovecot/core/commit/18d4bda11663bfdf8c06a39ff505dace77e134b8
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-data.c

  Log Message:
  -----------
  lib-smtp: server: Fix error message logged for errors occurring in data wrapper stream during DATA transfer.

Used the connection stream rather than the data stream to obtain the error.
Obviously, there is no error on the low-level connection when there is a data
istream (e.g. message size) error.

  Commit: 8b684fefc9f4d3f7c2bf73263e5e08c2e2f1254e
      https://github.com/dovecot/core/commit/8b684fefc9f4d3f7c2bf73263e5e08c2e2f1254e
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M configure.ac
    A m4/uoff_t_max.m4

  Log Message:
  -----------
  configure: Create a definition for UOFF_T_MAX.

  Commit: 61e6108ec3f079da41e84bba1886d195cfb13af5
      https://github.com/dovecot/core/commit/61e6108ec3f079da41e84bba1886d195cfb13af5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib-smtp/smtp-command-parser.c

  Log Message:
  -----------
  lib-smtp: command parser: Provide more details in command data size limit error.

  Commit: e34b3445bd4acde3b968d2da72da0a6ac01a2d91
      https://github.com/dovecot/core/commit/e34b3445bd4acde3b968d2da72da0a6ac01a2d91
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-data.c
    M src/lib-smtp/smtp-server-cmd-helo.c
    M src/lib-smtp/smtp-server-cmd-mail.c
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server-private.h
    M src/lib-smtp/smtp-server.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: Implement enforcement of maximum message size.

  Commit: 0d48428097abff8f590fe2717b67b3521d2df085
      https://github.com/dovecot/core/commit/0d48428097abff8f590fe2717b67b3521d2df085
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lmtp/commands.c

  Log Message:
  -----------
  lmtp: Actively enforce message size limit while copying message data.

This is actually currently not relevant to LMTP, but for future implementation
this code is added here already.

  Commit: 8f863c4b7211ade23f056e0b9b885af7d7861021
      https://github.com/dovecot/core/commit/8f863c4b7211ade23f056e0b9b885af7d7861021
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/submission/cmd-data.c

  Log Message:
  -----------
  submission: Actively enforce message size limit while copying message data.

  Commit: d5ee437f0622360f38d56badcab4fd6c106eaf48
      https://github.com/dovecot/core/commit/d5ee437f0622360f38d56badcab4fd6c106eaf48
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lmtp/client.c

  Log Message:
  -----------
  lmtp: Explicitly disable message size limit enforcement.

  Commit: bfd112eb835f315da84bf71a403f27d1a4e09c8f
      https://github.com/dovecot/core/commit/bfd112eb835f315da84bf71a403f27d1a4e09c8f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/submission/submission-client.c
    M src/submission/submission-settings.c

  Log Message:
  -----------
  submission: Truly enforce a configurable message size limit (default 40 MB).

Before, it was only checking a provided SIZE parameter to the MAIL command and
not the size of the actually submitted message.

  Commit: 8b052f502bde67e1fb014ab13e80b3030c380e3b
      https://github.com/dovecot/core/commit/8b052f502bde67e1fb014ab13e80b3030c380e3b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Fix the enforcement of the maximum DATA command message size.

The global setting from the server object was used, rather than the
per-connection setting. The latter is usually the one that is properly set,
while the global server setting is left at zero. For LMTP this meant that the
40 Mb implicit limit was still in force.

  Commit: 9422fd782809a3344b8d51cadb106851153c44f8
      https://github.com/dovecot/core/commit/9422fd782809a3344b8d51cadb106851153c44f8
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib-ssl-iostream/iostream-openssl-common.c

  Log Message:
  -----------
  lib-ssl-iostream: Fix missing altName handling in openssl_cert_match_name

If name is not found in subjectAltNames, report it as error.

Fixes Panic: file iostream-openssl-common.c: line 177 (openssl_cert_match_name): assertion failed: (*reason_r != NULL)

  Commit: b2bae07836e882d290a9b812a3275581ec94bf67
      https://github.com/dovecot/core/commit/b2bae07836e882d290a9b812a3275581ec94bf67
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib-ssl-iostream/iostream-openssl.c

  Log Message:
  -----------
  lib-ssl-iostream: Do not skip cert name check if invalid cert is allowed

Caller should be responsible for ignoring this error, not us.
All the locations calling here are dealing this correctly.

  Commit: edbed11e3902325cfc70f279ce97734d4d8c8d49
      https://github.com/dovecot/core/commit/edbed11e3902325cfc70f279ce97734d4d8c8d49
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib-http/test-http-client.c

  Log Message:
  -----------
  lib-http: test-http-client - Test against missing SAN name

Add test to make sure http client validates and ignores
missing subjectAltName in cert, when not validating names.

  Commit: 0313b5f1d094fd0f71fdf235893791b299ea588c
      https://github.com/dovecot/core/commit/0313b5f1d094fd0f71fdf235893791b299ea588c
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib-http/test-http-client.c

  Log Message:
  -----------
  lib-http: test-http-client - Only load existing CAs

Otherwise the SSL tests do not properly work.

Fixes Error: HTTP Request failed: Couldn't initialize SSL context: Can't load CA certs from directory /etc/ssl/certs: error:02001002:system library:fopen:No such file or directory: fopen('/etc/pki/tls/cert.pem','r'), error:2006D080:BIO routines:BIO_new_file:no such file, error:0B084002:x509 certificate routines:X509_load_cert_crl_file:system lib

  Commit: 05808c7ce699fdaf518b67248807533a663d9cb1
      https://github.com/dovecot/core/commit/05808c7ce699fdaf518b67248807533a663d9cb1
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib/murmurhash3.c
    M src/lib/test-murmurhash3.c

  Log Message:
  -----------
  lib: murmurhash3 produces bytes (not uint32_t's)

  Commit: c1ca270488c3bc617d6cf7b1292e60b51e8e5167
      https://github.com/dovecot/core/commit/c1ca270488c3bc617d6cf7b1292e60b51e8e5167
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/lib/test-murmurhash3.c

  Log Message:
  -----------
  lib: Simplify murmurhash3 LP64 vs. IPL32 test vectors

Compare: https://github.com/dovecot/core/compare/0d48dd64ff2b...c1ca270488c3
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.