[dovecot/pigeonhole] 13896b: global: Replace str_append_n() with str_append_dat...

[GitHub]

  Branch: refs/heads/release-0.5.3
  Home:   https://github.com/dovecot/pigeonhole
  Commit: 13896b2bf896bc6acbb2274cae4681d10cf308bc
      https://github.com/dovecot/pigeonhole/commit/13896b2bf896bc6acbb2274cae4681d10cf308bc
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-08-30 (Thu, 30 Aug 2018)

  Changed paths:
    M src/lib-managesieve/managesieve-quote.c
    M src/lib-sieve/ext-encoded-character.c
    M src/lib-sieve/mcht-matches.c
    M src/lib-sieve/plugins/imap4flags/ext-imap4flags-common.c
    M src/lib-sieve/plugins/mime/cmd-extracttext.c
    M src/lib-sieve/plugins/notify/ext-notify-common.c
    M src/lib-sieve/plugins/regex/mcht-regex.c
    M src/lib-sieve/plugins/variables/ext-variables-arguments.c
    M src/lib-sieve/sieve-message.c
    M src/lib-sieve/storage/ldap/sieve-ldap-db.c
    M src/lib-sieve/util/edit-mail.c
    M src/lib-sieve/util/rfc2822.c
    M src/lib-sieve/util/test-edit-mail.c
    M src/managesieve-login/client-authenticate.c
    M src/testsuite/testsuite-arguments.c

  Log Message:
  -----------
  global: Replace str_append_n() with str_append_data().

The str_append_n() function is now deprecated. At no occasion, the occurence of
NUL in the data is possible or relevant, so each instance is replaced with
str_append_data() rather than str_append_max().


  Commit: 708989e767692f783358a24c1811956c63ffb097
      https://github.com/dovecot/pigeonhole/commit/708989e767692f783358a24c1811956c63ffb097
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M src/lib-sieve/util/rfc2822.c

  Log Message:
  -----------
  lib-sieve: util: rfc2822: Fix assert panic occurring in rfc2822_header_append().

Panic was: "Buffer write out of range"

With some rather weird (sender-provided!) input, the header folding algorithm
got confused, causing a pointer to the start of the current line to exceed the
parsing pointer. This caused str_append_data() to be called with a negative
size. Added an assertion to make any future similar problems more obvious.


  Commit: b2f040600ac60961dcea750d3a22d53cf5c6d74c
      https://github.com/dovecot/pigeonhole/commit/b2f040600ac60961dcea750d3a22d53cf5c6d74c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M src/lib-sieve/util/rfc2822.c

  Log Message:
  -----------
  lib-sieve: util: rfc2822: Prevent writing header lines with trailing whitespace in rfc2822_header_append().


  Commit: 1a21c640b6e93d4cdc871715966e48434927f2c3
      https://github.com/dovecot/pigeonhole/commit/1a21c640b6e93d4cdc871715966e48434927f2c3
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M src/lib-sieve/util/Makefile.am
    A src/lib-sieve/util/test-rfc2822.c

  Log Message:
  -----------
  lib-sieve: util: Add tests for rfc2822_header_write().


  Commit: d3ea6203c12ca1ffee7d9b2a9cf8559917e9e178
      https://github.com/dovecot/pigeonhole/commit/d3ea6203c12ca1ffee7d9b2a9cf8559917e9e178
  Author: Phil Carmody <phil at dovecot.fi>
  Date:   2018-09-23 (Sun, 23 Sep 2018)

  Changed paths:
    M src/lib-sieve-tool/sieve-tool.c
    M src/lib-sieve/plugins/environment/ext-environment-common.c
    M src/lib-sieve/plugins/notify/ext-notify-common.c
    M src/lib-sieve/plugins/vacation/cmd-vacation.c
    M src/lib-sieve/storage/file/sieve-file-storage-save.c
    M src/lib-sieve/storage/file/sieve-file-storage.c
    M src/lib-sieve/storage/ldap/sieve-ldap-db.c
    M src/plugins/doveadm-sieve/doveadm-sieve-sync.c

  Log Message:
  -----------
  global: replace verbose strncmp()s with simpler str_begin()s

Signed-off-by: Phil Carmody <phil at dovecot.fi>


  Commit: dbf75439da34f68dd47500ed7e6307ac2f484246
      https://github.com/dovecot/pigeonhole/commit/dbf75439da34f68dd47500ed7e6307ac2f484246
  Author: Phil Carmody <phil at dovecot.fi>
  Date:   2018-09-23 (Sun, 23 Sep 2018)

  Changed paths:
    M src/lib-sieve/storage/ldap/sieve-ldap-db.c

  Log Message:
  -----------
  ldap - fix stupid typo

Signed-off-by: Phil Carmody <phil at dovecot.fi>


Compare: https://github.com/dovecot/pigeonhole/compare/a10af5b2f368...dbf75439da34
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.