[dovecot/core] 0c8cee: doveadm: Make sure to stop running commands requir...

[GitHub]

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 0c8cee931fe76d2899041e7feee0ebbeb15f72f6
      https://github.com/dovecot/core/commit/0c8cee931fe76d2899041e7feee0ebbeb15f72f6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M src/director/doveadm-connection.c
    M src/director/doveadm-connection.h
    M src/director/main.c

  Log Message:
  -----------
  doveadm: Make sure to stop running commands requiring synced ring when ring is no longer synced

A command could desync the ring, and no more commands should be run
afterwards.

This also fixes a bug where a command that desyncs the ring is supposed to
wait for the ring being synced before returning OK, but returns it
immediately instead.


  Commit: d5ab2c08d98609f16185715b413d4a16b099e156
      https://github.com/dovecot/core/commit/d5ab2c08d98609f16185715b413d4a16b099e156
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M src/director/doveadm-connection.c

  Log Message:
  -----------
  director: Add assert to make sure doveadm connection's IO isn't added multiple times


  Commit: 110d5f08648368fe6b9d32959153504ba55853ca
      https://github.com/dovecot/core/commit/110d5f08648368fe6b9d32959153504ba55853ca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M src/director/doveadm-connection.c

  Log Message:
  -----------
  director: Fix assert-crash when doveadm disconnects immediately after sending command

Any command that requires a ring sync should cause the doveadm connection to
wait until the ring is synced. However, if the disconnection happened early
enough the connection is deinitialized before the ring sync is finished.

Fixes:
Panic: file doveadm-connection.c: line 1097 (doveadm_connection_deinit): assertion failed: (conn->to_ring_sync_abort == NULL)


Compare: https://github.com/dovecot/core/compare/52dc695d7618...110d5f086483
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.