[dovecot/core | refs/heads/master] 5824e33d: lib-smtp: client: Move connection to TRANSACTION state immediately when a transaction is started.

[noreply at dovecot.org]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 5824e33db25fee19eb394d182745b1e58922fb74
      https://github.com/dovecot/core/commit/5824e33db25fee19eb394d182745b1e58922fb74
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-12-27 (Thu, 27 Dec 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: client: Move connection to TRANSACTION state immediately when a transaction is started.

Before, it waited until the actual start handler was called from timeout, but
that causes a race condition with mtp_client_connection_abort_transaction(),
which in turn causes an assert panic.

Panic was:

Panic: file smtp-client-connection.c: line 2153 (smtp_client_connection_abort_transaction): assertion failed: (conn->state != SMTP_CLIENT_CONNECTION_STATE_READY)

  Patch: https://github.com/dovecot/core/compare/fbeccd7f11ec...5824e33db25f.patch