[dovecot/core | refs/heads/release-2.3.5] 51320866: Released v2.3.5.

[noreply at dovecot.org]

  Branch: refs/heads/release-2.3.5
  Home:   https://github.com/dovecot/core
  Commit: 513208660bb46d7679ffe2ffc5d2021ec26eb4b3
      https://github.com/dovecot/core/commit/513208660bb46d7679ffe2ffc5d2021ec26eb4b3
  Author: Timo Sirainen <timo.sirainen at open-xchange.com>
  Date:   2019-03-04 (Mon, 04 Mar 2019)

  Changed paths:
    M NEWS
    M configure.ac

  Log Message:
  -----------
  Released v2.3.5.

  Commit: cb6af3a04cc00cfa2af9018b535169d7c75ab2d1
      https://github.com/dovecot/core/commit/cb6af3a04cc00cfa2af9018b535169d7c75ab2d1
  Author: Timo Sirainen <timo.sirainen at open-xchange.com>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M src/lib-fs/fs-posix.c

  Log Message:
  -----------
  fs-posix: fs_read_stream() - Don't close file's fd

This is especially important with newly created files, because they may
still be accessed after reading. The next file access attempt after
fs_read_stream() might cause the file to be recreated and crash.

Fixes:
Panic: file fs-posix.c: line 252 (fs_posix_create): assertion failed: (file->temp_path == NULL)

  Commit: 8cfb03a1f8a7f5ccd60e50c7d52a5a5542fd97f2
      https://github.com/dovecot/core/commit/8cfb03a1f8a7f5ccd60e50c7d52a5a5542fd97f2
  Author: Timo Sirainen <timo.sirainen at open-xchange.com>
  Date:   2019-02-20 (Wed, 20 Feb 2019)

  Changed paths:
    M src/lib/test-istream-seekable.c

  Log Message:
  -----------
  lib: test-istream-seekable - Add asserts to make sure blocking state changes at EOF

  Commit: ba43795f2d3d5c5b192005131ad64fc67acc65e2
      https://github.com/dovecot/core/commit/ba43795f2d3d5c5b192005131ad64fc67acc65e2
  Author: Timo Sirainen <timo.sirainen at open-xchange.com>
  Date:   2019-02-20 (Wed, 20 Feb 2019)

  Changed paths:
    M src/lib-storage/mail.c

  Log Message:
  -----------
  lib-storage: mail_get_*stream*() - Assert that returned streams are blocking

Several callers already rely on them being blocking. Making these asserts
explicit makes sure that any bugs are caught early.

  Commit: c71f089f5efae1b4ec51988a8fcad2653e23675d
      https://github.com/dovecot/core/commit/c71f089f5efae1b4ec51988a8fcad2653e23675d
  Author: Timo Sirainen <timo.sirainen at open-xchange.com>
  Date:   2019-02-20 (Wed, 20 Feb 2019)

  Changed paths:
    M src/lib/istream-seekable.c

  Log Message:
  -----------
  lib: istream-seekable - Change stream to be blocking=TRUE after reaching EOF

After EOF is reached, the stream is now fully read into file or memory.
read()s can no longer return 0, so blocking=TRUE can be used.

Some callers were reusing the seekable stream in places that required
blocking=TRUE.

Fixes at least with imapsieve vnd.dovecot report extension:
Panic: file ostream.c: line 427 (o_stream_nsend_istream): assertion failed: (instream->blocking)

  Commit: a57998e76e9b969c90ff1cd21f67e5e58b98b5ed
      https://github.com/dovecot/core/commit/a57998e76e9b969c90ff1cd21f67e5e58b98b5ed
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-ssl-iostream/iostream-ssl-test.c

  Log Message:
  -----------
  lib-ssl-iostream: iostream-ssl-test - Update the test certificate to have very long expiry period.

The old certificate expired after one year, which causes all kinds of unit test
failures.

  Patch: https://github.com/dovecot/core/compare/a57998e76e9b^...513208660bb4.patch