[Dovecot] bug in openssl proxy code (1.0-test24) ?

[Timo Sirainen]

On Fri, 2004-07-09 at 15:05, Andrey Panin wrote:
> On 191, 07 09, 2004 at 02:46:46PM +0300, Timo Sirainen wrote:
> > On Fri, 2004-07-09 at 14:08, Andrey Panin wrote:
> > > If client connects to pop3 server, issues STLS command and
> > > then drops connection dovecot starts flooding syslog with
> > > this message repeated endlessly:
> > > 
> > > Jul  9 14:31:40 smtp dovecot: pop3-login: SSL_accept() syscall failed: EOF [80.254.111.9]
> > 
> > So it seems. Before 1.0 I'll have to check all of my code that uses
> > refcounting. That's annoyingly difficult to get right..
>  
> May be I don't understand something, but it looks like proxy->refcount
> simply can't reach zero here. Initial refcount value is 2, each call
> to ssl_step() callback increments it and even if ssl_proxy_destroy()
> called refcount is stil > 0. I'm confused :(

Yes, it didn't get to zero always. ssl_step() increased it but also
decreased it. It dropped from 2 -> 1 when connection was closed, and 1
-> 0 in ssl_proxy_free() which pop3-login code called. Or at least it
should have worked that way. Fixed in CVS:
http://dovecot.org/list/dovecot-cvs/2004-July/002902.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20040709/b529a5a3/attachment.pgp