[Dovecot] UID confusion

[Timo Sirainen]

On 28.6.2005, at 11:39, Andrew Hutchings wrote:

> 2 or 3 customers have reported that they are having problems 
> downloading their mail via. POP3.  I have attached the rawlogs of 
> their transactions and the UID list at the time.  Is this because I am 
> using an incompatible UID format or is something else at fault?  
> Deleting the UID list and indexes fixes the problem.  I am using 
> Test72.

Sounds a bit like the Thunderbird problem..

..
> -ERR Message is deleted.
> -ERR Message is deleted.
> -ERR Message is deleted.
> -ERR Too many bad commands.

But this is why it really fails. Dovecot disconnects the client here. 
Hmm. I'll make the disconnection happen only when sending enough (20) 
unknown commands, not when sending known commands but with invalid 
parameters. This should fix it:

Index: client.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/pop3/client.c,v
retrieving revision 1.55
diff -u -r1.55 client.c
--- client.c	28 May 2005 11:20:49 -0000	1.55
+++ client.c	28 Jun 2005 09:52:24 -0000
@@ -351,7 +351,7 @@
  		else
  			*args++ = '\0';

-		if (client_command_execute(client, line, args)) {
+		if (client_command_execute(client, line, args) >= 0) {
  			client->bad_counter = 0;
  			if (client->cmd != NULL) {
  				o_stream_set_flush_pending(client->output,
Index: commands.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/pop3/commands.c,v
retrieving revision 1.44
diff -u -r1.44 commands.c
--- commands.c	23 May 2005 19:46:27 -0000	1.44
+++ commands.c	28 Jun 2005 09:52:24 -0000
@@ -688,5 +688,5 @@
  	}

  	client_send_line(client, "-ERR Unknown command: %s", name);
-	return FALSE;
+	return -1;
  }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20050628/f8292af9/PGP.pgp