[Dovecot] Bug: maidirsize double counting moved messages

[Bill Boebel]

On Wed, April 26, 2006 10:37, Bill Boebel said:
> On Fri, April 21, 2006 15:01, Bill Boebel <bill at webmail.us> said:
> > The maildirsize file is double counting messages when moving them from
> > folder to folder when "maildir_copy_with_hardlinks = no":
> >
> > When I change "maildir_copy_with_hardlinks" to "yes", this problem only
> > occurs when moving in and out of the INBOX, but not when moving from
> > subfolder to subfolder:
>
> Well... I don't think this is the correct fix below, but it did the trick
> in our environment when maildir_copy_with_hardlinks=yes.  I think the real
> problem is that quota_default_alloc() is getting called twice.  Once from
> somewhere in mail_storage_copy() -> maildir_copy() -> mailbox_save_init(),
> and a second time somewhere after that.
>
> src/lib-storage/index/maildir/maildir-copy.c
> @136
>
> <       if (mbox->storage->copy_with_hardlinks &&
> <           mail->box->storage == mbox->ibox.box.storage) {
> ---
> >       if (mbox->storage->copy_with_hardlinks) {
>

This size doubling is happening for any IMAP APPEND operation as well.  It
has been a pretty annoying bug, because we have to keep manually deleting
maildirsize files to fix mailboxes so that they don't bounce mail due to
the quota miscalculation.  Timo, is this something you could take a look
at?

Thanks,
Bill