[Dovecot] MANAGESIEVE patch v4 for dovecot 1.0.rc28

Uldis Pakuls neko at it4u.lv
Thu Apr 19 18:36:01 EEST 2007


Stephan Bosch wrote:
> Hello dovecot users,
>
> I have updated the MANAGESIEVE patch to fix the currently known small
> problems with the protocol implementation. It is designed for rc28,
> but also compiles cleanly with the current cvs branch_1_0.
>
> Have fun testing the patch. Notify me when there are problems.
>
> Regards,
>
> -- 
> Stephan Bosch
> stephan at rename-it.nl
> IRC: Freenode, #dovecot, S[r]us
>

There is problem; after patch dovecot segfaults if you try to dump settings.

file: ./src/master/master-stettings.c

in "void master_setting_dump ..."

    const void *sets [4]
    const char *set_names[4]

must be changed to:
    const void *sets [5]
    const char *set_names[5]

after you added managesieve settings here, settings max count must be
increased too:)

-------- patch -------
# diff -r -u -N master-settings.c master-settings.c.new
--- master-settings.c   2007-04-17 07:48:04.000000000 +0200
+++ master-settings.c.new       2007-04-19 18:33:02.000000000 +0200
@@ -1584,8 +1584,8 @@
 
 void master_settings_dump(struct server_settings *set, bool nondefaults)
 {
-       const void *sets[4];
-       const char *set_names[4];
+       const void *sets[5];
+       const char *set_names[5];
        unsigned int count;
 
        sets[0] = &default_settings;

---------------------

Uldis


More information about the dovecot mailing list