[Dovecot] MANAGESIEVE patch v5 for dovecot 1.0.2

[Robin Breathe]

Timo Sirainen wrote:
> On Wed, 2007-08-15 at 15:29 +0100, Robin Breathe wrote:
>> Stephan Bosch wrote:
>>> Have fun testing the patch. Notify me when there are problems.
>> Stephan,
>>
>> There's a small problem with your patch as it stands: it depends on a
>> number of GCCisms, and fails to compile with, for example, Sun CC under
>> Solaris 10.
>> Removing all of your "__attribute__((unused))" declarations goes some
>> way, but the build then fails with the following:
> 
> These can be replaced with __attr_unused__.

Great.

>> "sieve-implementation.c", line 193: void function cannot return value
>> cc: acomp failed for sieve-implementation.c
>>
>> A reasonable error given that sieve_runenv_mark_duplicate() is a void
>> function with a return :) Removing the "return" leads to a clean build,
>> but it's not clear what implications that might have.
> 
> Probably just an accidental mistake. I've had the same problem when
> changing return values to voids. It's annoying that gcc doesn't complain
> about this.

Fair enough, you think that removing the return is safe/correct then?

On a side-note, I've not seen anything from you to indicate whether the
managesieve functionality will be integrated into a future release. Any
thoughts?

Regards,
Robin