[Dovecot] quota vs. antispam issue

[Johannes Berg]

On Fri, 2008-07-18 at 20:58 +0300, Timo Sirainen wrote:

> So the quota code eventually sees both ctx->dest_mail = NULL and qt- 
>  >tmp_mail = NULL. I'm not really sure what the right fix for this  
> is.. ctx->dest_mail should be set by something. Perhaps if quota/ 
> antispam overrides it it should set it, and mailbox_save_init()  
> shouldn't set it if it's already set..

Ok, that seems to work, but I think a better alternative would probably
be to make dest_mail a struct mail ** like the context.

Alternatively, we could ensure that dest_mail is never NULL to start
with, and have mailbox_save_init() create one, but I'm not sure about
the performance implications of that. The plugins could, if that's
possible (haven't checked) set those flags of what they require, and if
there are no plugins then a struct mail with no MAIL_FETCH_* flags
wouldn't hurt much, would it?

johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20080718/78d29aa9/attachment.bin