[Dovecot] Bug in keywords conversion with courier-dovecot-migrate.pl v1.1.7

Timo Sirainen tss at iki.fi
Mon Sep 22 20:45:54 EEST 2008


On Fri, 2008-09-19 at 11:03 -0500, John Lightsey wrote:
> >> # read updates from the directory
> >> my %updates;
> >> foreach (<$keyword_dir/*>) {
> >>
> >> This isn't going to pick up any files beginning with a dot, so most  
> >> of the update files in the courierimapkeywords directory are going  
> >> to be skipped.
> >
> > Any suggestions how to best fix it? My Perl knowledge isn't too good.
> >
> 
> opendir/readdir/closedir...  Personally I avoid file globs in Perl  
> whenever possible because of the tricks and limitations involved with  
> them.  For instance, if the glob expands to more than GLOB_LIMIT files  
> what is going to happen?  opendir/readdir/closedir has very  
> predictable behavior.
> 
> Actually since we're talking about that, scan_maildir() is very likely  
> to hit the glob limit.  It should also be switched to readdir.  The  
> maildir files update loop in convert_subscriptions() as well.

Thanks, I updated all of them and uploaded v1.1.8.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20080922/ba45ab8f/attachment.bin 


More information about the dovecot mailing list