[Dovecot] Deliver error - fdatasync_path

[Timo Sirainen]

On Thu, 2009-03-05 at 14:42 -0800, Daniel L. Miller wrote:
> > With dbox yes, you can just ignore the error. Maildir probably would
> > give user-visible errors.
> >
> >   
> Why the difference?  I can see a big deal for mbox - but why Maildir?

It's just because of how the code was written. In maildir code if
fdatasync_path() returns -1, the code continues returning -1 which
eventually causes the entire operation to fail and an error be returned
to user.

With dbox the code just didn't bother checking if fdatasync_path()
returned -1 or 0. With mbox it never even calls that function.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20090305/012d61c5/attachment.bin