[Dovecot] Patch to fix leak in imap_refresh_proctitle in beta[5, 6]

[Timo Sirainen]

On Mon, 2010-06-14 at 17:18 -0500, Mike Abbott wrote:
> 6   imap                                0x0000000105867333 imap_refresh_proctitle + 218 ->
> 7   imap                                0x000000010585f18e client_command_input + 190 ->

Looks ok..

> 6   imap                                0x0000000105867333 imap_refresh_proctitle + 218 ->
> 7   imap                                0x00000001058666ce cmd_sync_continue + 199 ->

But how does this happen? Did it optimize away some functions or have
you added more imap_refresh_proctitle() calls?

> And perhaps there should be a warning when data is allocated out of
> the primordial data stack (as opposed to a nested one)?

But it's not. It always frees the memory when returning back to ioloop.
I could understand if it wasted a few kilobytes of memory, but how do
you manage to make it call imap_refresh_proctitle() millions of times
without returning to ioloop?