[Dovecot] quota_set leak

Mike Abbott michael.abbott at apple.com
Wed Jun 23 01:07:20 EEST 2010


The quota plugin in 2.0.beta6 leaks 2KB "quota settings" pools.  Here is a patch to plug this leak, assuming you intended the caller of quota_init to retain ownership of the quota_set.  If on the other hand you intended for quota_init to assume ownership of the quota_set, then the quota_settings_deinit call belongs in quota_deinit.

--- a/src/plugins/quota/quota-storage.c	(beta6)
+++ b/src/plugins/quota/quota-storage.c	(patched)
@@ -427,6 +427,7 @@
 {
 	struct quota_user *quser = QUOTA_USER_CONTEXT(user);
 
+	quota_settings_deinit(&quser->quota->set);
 	quota_deinit(&quser->quota);
 	quser->module_ctx.super.deinit(user);
 }



More information about the dovecot mailing list