[Dovecot] qmail-secretary plugin for dovecot deliver
rajkumars at gmail.com
Tue Mar 16 17:11:24 EET 2010
On Tue, Mar 16, 2010 at 5:50 PM, Timo Sirainen <tss at iki.fi> wrote:
> That seems like a feature that's unlikely to be used by many people,
> even more so because it requires LDAP. It's fine if it's listed in
> http://wiki.dovecot.org/Plugins, but I don't think I'll add it to
> Dovecot distribution itself.
That's fine, I am willing to maintain and update the plugin as required.
> Could you do all this work before even calling deliver? Like:
> deliver -a user-action-hash at domain.com -d user at domain.com
> So the lookup is done for user, but the full address is still available.
Okay. I am not sure I fully understand this statement, but let me try
again before coming back to the list.
> Currently the only LDAP config for Dovecot is for authentication. I
> don't think other stuff should necessarily read that same config. The
> whole LDAP stuff should be more abstracted out, so that e.g. dict-ldap
> could also be created, but that's a bigger job.
If you could elaborate on the ldap-dict I can try and code that up.
> mail_user_get_temp_prefix() returns a path/prefix for a temporary file
> you can create.
> But anyway, most importantly: get rid of those ugly insecure C string
> handling functions! Dovecot has tons of different ways to handle strings
> in an easier way: http://wiki.dovecot.org/Design/Strings I'd probably
> change most of them to t_strdup_printf() and maybe some string builders
> to string_t.
> chomp() also seems unnecessary. There shouldn't be LFs in any of those
> strings. And if there are, they probably shouldn't be removed..
Thanks for your review, I shall address these and post the updated plugin.
More information about the dovecot