[Dovecot] A questions about consume_results (driver-pgsql.c)

Timo Sirainen tss at iki.fi
Sat Mar 27 04:13:09 EET 2010

On Thu, 2010-03-25 at 20:04 +0100, Rainer Weikusat wrote:
> This is the only part of the driver-pgsql.c code where a
> CONNECTION_BAD does not result in driver_pgsql_close being called.
> This will likely happen after the next query (from queue or a new one)
> failed because the connection was bad. Is there a reason for this?

Maybe it would be ok, but it's a bit risky change. It's possible that
closing the connection at that point frees some memory that some code
later still tries to use.

Although a quick look at the code shows that it's probably safe.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20100327/19e7acef/attachment.bin 

More information about the dovecot mailing list