[Dovecot] Dovecot 2.0.5 and BSDI 4.3 again

[The Doctor]

On Thu, Oct 14, 2010 at 04:45:00PM +0100, Timo Sirainen wrote:
> On Sun, 2010-10-10 at 17:02 -0600, The Doctor wrote:
> 
> > Oct 10 16:30:45 doctor dovecot: log: Error: net_accept() failed: Invalid argument
> 
> So my check below doesn't work. Add here:
> 
> if (errno != EINVAL)
>   i_error("errno = %d %m");
> else if (fstat(l->fd, &st) < 0)
>   i_error("fstat() failed: %m");
> else
>   i_error("mode=%o & fifo = %d", st.st_mode, S_ISFIFO(st.st_mode));
> fd_debug_verify_leaks(l->fd, l->fd); // should show what it is if it's not a fifo..
> 
> 
> >                 if (errno == ENOTSOCK) {
> >                         /* it's not a socket. should be a fifo. */
> >                 } else if (errno == EINVAL &&
> >                            (fstat(l->fd, &st) < 0 || !S_ISFIFO(st.st_mode))) {
> >                         /* BSDI fails accept(fifo) with EINVAL. */
> 


Log reveals


Oct 14 22:38:49 doctor dovecot: master: Dovecot v2.0.5 starting up (core dumps disabled)
Oct 14 22:38:49 doctor dovecot: log: Error: conn.fd: -2
Oct 14 22:38:49 doctor dovecot: log: Error: l->fd: 20
Oct 14 22:38:49 doctor dovecot: log: Error: &conn.remote_ip: 134511880
Oct 14 22:38:49 doctor dovecot: master: Error: service(anvil): child 7645 killed with signal 6 (core dumps disabled)
Oct 14 22:38:49 doctor dovecot: log: Error: &conn.remote_port: 134511900
Oct 14 22:38:49 doctor dovecot: log: Error: mode=140000 & fifo = 1
Oct 14 22:38:49 doctor dovecot: master: Error: service(anvil): command startup failed, throttling
Oct 14 22:38:49 doctor dovecot: log: Panic: Leaked socket fd 20: (null):0 -> (null):0
Oct 14 22:38:49 doctor dovecot: master: Error: service(log): child 7646 killed with signal 6 (core dumps disabled)
Oct 14 22:38:49 doctor dovecot: master: Error: service(log): command startup failed, throttling
Oct 14 22:38:49 doctor dovecot: master: Error: service(imap-login): command startup failed, throttling
Oct 14 22:38:49 doctor dovecot: master: Error: service(pop3-login): command startup failed, throttling  

-- 
Member - Liberal International	This is doctor at nl2k.ab.ca Ici doctor at nl2k.ab.ca
God, Queen and country! Never Satan President Republic! Beware AntiChrist rising! 
http://twitter.com/rootnl2k http://www.facebook.com/dyadallee
Are you a real human: http://www.cuttingedge.org/news/n1334.cfm