[Dovecot] Dovecot 2.0.5 and BSDI 4.3 again

[The Doctor]

On Fri, Oct 15, 2010 at 10:34:10AM -0600, The Doctor wrote:
> On Fri, Oct 15, 2010 at 10:19:37AM -0600, The Doctor wrote:
> > On Fri, Oct 15, 2010 at 04:17:25PM +0100, Timo Sirainen wrote:
> > > On Thu, 2010-10-14 at 22:43 -0600, The Doctor wrote:
> > > > > >                 } else if (errno == EINVAL &&
> > > > > >                            (fstat(l->fd, &st) < 0 || !S_ISFIFO(st.st_mode))) {
> > > > > >                         /* BSDI fails accept(fifo) with EINVAL. */
> > > 
> > > Oh, the checks in this code were just wrong.
> > > http://hg.dovecot.org/dovecot-2.0/rev/3385e9028410 should finally fix
> > > that.
> > > 
> > 
> > Can you send me a diff file and I can try this out.
> >
> 
> Never mind, just typed the link in
> 
> and make the change.
> 
> I will test later.

The logs still show

Oct 15 20:36:24 doctor dovecot: master: Dovecot v2.0.5 starting up (core dumps disabled)
Oct 15 20:36:24 doctor dovecot: log: Error: conn.fd: -2
Oct 15 20:36:24 doctor dovecot: log: Error: l->fd: 20
Oct 15 20:36:24 doctor dovecot: log: Error: &conn.remote_ip: 134511880
Oct 15 20:36:24 doctor dovecot: log: Error: &conn.remote_port: 134511900
Oct 15 20:36:24 doctor dovecot: log: Error: mode=140000 & fifo = 1
Oct 15 20:36:24 doctor dovecot: log: Panic: Leaked socket fd 20: (null):0 -> (null):0
Oct 15 20:36:24 doctor dovecot: master: Error: service(log): child 24779 killed with signal 6 (core dumps disabled)
Oct 15 20:36:24 doctor dovecot: master: Error: service(log): command startup failed, throttling
Oct 15 20:36:24 doctor dovecot: master: Error: service(anvil): child 24778 killed with signal 6 (core dumps disabled)
Oct 15 20:36:24 doctor dovecot: master: Error: service(anvil): command startup failed, throttling
Oct 15 20:36:25 doctor dovecot: master: Error: service(imap-login): command startup failed, throttling
Oct 15 20:36:25 doctor dovecot: master: Error: service(pop3-login): command startup failed, throttling 

>  
> > -- 
> > Member - Liberal International	This is doctor at nl2k.ab.ca Ici doctor at nl2k.ab.ca
> > God, Queen and country! Never Satan President Republic! Beware AntiChrist rising! 
> > http://twitter.com/rootnl2k http://www.facebook.com/dyadallee
> > Are you a real human: http://www.cuttingedge.org/news/n1334.cfm
> 
> -- 
> Member - Liberal International	This is doctor at nl2k.ab.ca Ici doctor at nl2k.ab.ca
> God, Queen and country! Never Satan President Republic! Beware AntiChrist rising! 
> http://twitter.com/rootnl2k http://www.facebook.com/dyadallee
> Are you a real human: http://www.cuttingedge.org/news/n1334.cfm

-- 
Member - Liberal International	This is doctor at nl2k.ab.ca Ici doctor at nl2k.ab.ca
God, Queen and country! Never Satan President Republic! Beware AntiChrist rising! 
http://twitter.com/rootnl2k http://www.facebook.com/dyadallee
Are you a real human: http://www.cuttingedge.org/news/n1334.cfm