[Dovecot] File descriptor leak in sieve-extprograms

[Kirill A. Shutemov]

On Sat, Dec 21, 2013 at 03:18:31PM +0100, Stephan Bosch wrote:
> On 12/14/2013 5:39 PM, Kirill A. Shutemov wrote:
> > Stephan Bosch wrote:
> >> On 12/13/2013 11:14 PM, Kirill A. Shutemov wrote:
> >>> Stephan Bosch wrote:
> >>>> This probably fixes it, although I am not entirely sure. I am mainly a
> >>>> bit puzzled on how this causes the fd leak; the fd_in and fd_out are for
> >>>> the current backends always the same fd.
> >>> fd_in is not opened in my case: -1 all the way. I use vnd.dovecot.pipe.
> >> Ah right, that explains it.
> >>
> >>> I've hackaround sieve-filter crash with the ugly patch. I don't know how to fix
> >>> this properly.
> >> Could you provide more details of your setup (configuration,
> >> sieve-filter command line, Sieve script), so that I can reproduce the
> >> problem at this end?
> > Command:
> >
> > sieve-filter -e -v -W ~/.dovecot.sieve INBOX expunge
> 
> This should fix it:
> 
> http://hg.rename-it.nl/dovecot-2.2-pigeonhole/rev/8612191c5069
> 
> I tested it here with several hundred thousand old spam e-mails.

Verified with valgrind too. Thanks.

-- 
 Kirill A. Shutemov