sis deduplication broken from 2.2.16 upwards

[Timo Sirainen]

On 08 Mar 2016, at 01:50, Pavel Stano <stanojr at websupport.sk> wrote:
> 
> 
> sis attachment deduplication is broken in 2.2.16 upwards.
> It is caused by this commit.
> https://github.com/dovecot/core/commit/664bf3e236c214aee86294483c379e4fa66c2e63
> 
> in src/lib-fs/fs-sis.c function fs_sis_try_link() is comparation of
> inodes of hash files.
> Because fs_stat() after that commit use fstat() on open fd of temporary
> file instead of stat on filename. But that temporary file has differnt
> inode.
> 
> It not cause any corruption but it will not save any space.
> Because every duplicate attachment will be in separate file.

Thanks, fixed: https://github.com/dovecot/core/commit/3b39022ea0513363241cf852b7d454c841584ea1