vacation problem with SRS

[Kacper Guzik]

i  Cant compile piegeon hole from github with this feature:

2822.c  -fPIC -DPIC -o .libs/rfc2822.o

*edit-mail.c:* In function '*edit_mail_set_cache_corrupted*':

*edit-mail.c:1665:3:* *error: *too many arguments to function '
*edmail->wrapped->v.set_cache_corrupted*'

   (&edmail->wrapped->mail, field, reason);

*   ^*

*edit-mail.c:* At top level:

*edit-mail.c:1694:2:* *warning: *initialization from incompatible pointer
type [enabled by default]

  edit_mail_get_backend_mail,

*  ^*

*edit-mail.c:1694:2:* *warning: *(near initialization for '
*edit_mail_vfuncs.get_real_mail*') [enabled by default]

*edit-mail.c:1701:2:* *warning: *initialization from incompatible pointer
type [enabled by default]

  edit_mail_set_cache_corrupted,

*  ^*

*edit-mail.c:1701:2:* *warning: *(near initialization for '
*edit_mail_vfuncs.set_cache_corrupted*') [enabled by default]

*edit-mail.c:1703:1:* *warning: *missing initializer for field '
*set_cache_corrupted_reason*' of '*struct mail_vfuncs*'
[-Wmissing-field-initializers]

 };

* ^*

In file included from *edit-mail.c:16:0*:

*/usr/local/include/dovecot/mail-storage-private.h:509:9:* *note: *'
*set_cache_corrupted_reason*' declared here

  void (*set_cache_corrupted_reason)(struct mail *mail,

*         ^*

make[4]: *** [edit-mail.lo] Error 1

make[4]: *** Waiting for unfinished jobs....

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../..
-I/usr/local/include/dovecot -DMODULEDIR=\"/usr/local/lib/dovecot\"
-std=gnu99 -g -O2 -Wall -W -Wmissing-prototypes -Wmissing-declarations
-Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast
-fno-builtin-strftime -Wstrict-aliasing=2 -I../../.. -MT rfc2822.lo -MD -MP
-MF .deps/rfc2822.Tpo -c rfc2822.c -o rfc2822.o >/dev/null 2>&1

mv -f .deps/rfc2822.Tpo .deps/rfc2822.Plo

make[4]: Leaving directory `/opt/pigeonhole-master/src/lib-sieve/util'

make[3]: *** [all-recursive] Error 1

make[3]: Leaving directory `/opt/pigeonhole-master/src/lib-sieve'

make[2]: *** [all-recursive] Error 1

make[2]: Leaving directory `/opt/pigeonhole-master/src'

make[1]: *** [all-recursive] Error 1

make[1]: Leaving directory `/opt/pigeonhole-master'

make: *** [all] Error 2



2017-08-24 2:13 GMT+02:00 Stephan Bosch <stephan at rename-it.nl>:

> Op 7/20/2017 om 8:24 PM schreef Kacper Guzik:
> > I have this version with FIXME
> >
> >
> >         /* FIXME: If From header of message has same address, we should
> use
> > that
> >
> >          * instead to properly include the phrase part.
> >
> >          */
> >
> >         rfc2822_header_printf(msg, "To", "<%s>", reply_to);
> >
> >
> >
> > This should be work ok? Or You must change something?
> >
> > 2017-07-20 15:51 GMT+02:00 Stephan Bosch <stephan at rename-it.nl>:
> >
> >>
> >> Op 20-7-2017 om 10:37 schreef Kacper Guzik:
> >>
> >> Hi i have similiar problem like here:
> >>> http://www.iredmail.org/forum/topic11833-iredmail-support-vo
> >>> cation-respone-unknown-user.html
> >>>
> >>>
> >>> email send :
> >>> from : web123 at gmail.com
> >>> to : jacka at mail.com
> >>>
> >>> vocation sent back
> >>> from : jacka at mail.com
> >>> to : srs0=hmc8=v7=gmail.com=web123 at mail.com
> >>>
> >>>
> >>>
> >>> postsrsd changing return-path from web123 at gmail.com to srs0=hmc8=v7=
> >>> gmail.com=web123 at mail.com
> >>>
> >>> this is no problem for me but  sieve:
> >>>
> >>> Vacation's messages are always addressed to the Return-Path address
> >>>
> >>> it is possible some how change this ugly to header to normal?
> >>>
> >>> I can't find anything on dovecot mailing lists
> >>>
> >> Hmm,
> >>
> >> I think this relates to this FIXME:
> >>
> >> https://github.com/dovecot/pigeonhole/blob/master/src/lib-
> >> sieve/plugins/vacation/cmd-vacation.c#L951
> >>
> >> Looks like I've been just lazy. Should be relatively easy to fix.
>
> I addressed the FIXME earlier already and I have this pending now:
>
> https://github.com/dovecot/pigeonhole/commit/
> 0e5ec449f701bdc293c5fdc2551d0a7b242703d7
>
> Regards,
>
> Stephan.
>