[PATCH] mail-storage.c: check against NULL address in strcmp() invocation

Timo Sirainen tss at iki.fi
Tue Jan 10 20:31:44 UTC 2017


On 10 Jan 2017, at 21.58, Michal Soltys <soltys at ziu.info> wrote:
> 
> Configurations with multiple shared namespaces can trigger a bug
> where the first argument of strcmp() invocation is NULL.
> 
> This patch adds an explicit check, analogously to how the second
> argument is sanitized.

I think it shouldn't be NULL though.. I'd rather add some asserts and figure out why it is. I guess the attached patch assert-crashes? What's the backtrace there?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff
Type: application/octet-stream
Size: 563 bytes
Desc: not available
URL: <http://dovecot.org/pipermail/dovecot/attachments/20170110/28a53c93/attachment-0001.obj>
-------------- next part --------------




More information about the dovecot mailing list