Compile problem on Solaris

[James]

On 10/06/2019 14:40, Roderick Johnstone via dovecot wrote:

> Compiling dovecot 2.2.36.1 with the native compiler on Solaris 10 is 
> giving the error below.
...
> -m64 -c -o sha3.lo sha3.c
> libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../.. 
> -I/export/home/exim_build_20190605/build_local/include -m64 -c sha3.c 
> -KPIC -DPIC -o .libs/sha3.o
> "sha3.h", line 49: warning: unnamed struct member
...

Untested: try naming the union. My own builds (dovecot 2.3.6) get 
through this.  What compiler version? 12.6 is current and does not issue 
the unnamed struct warning, eg, 12.3 does.

struct sha3_ctx {
     uint64_t saved;  /* the portion of the input message that we
               * didn't consume yet */
     union {      /* Keccak's state */
         uint64_t s[SHA3_KECCAK_SPONGE_WORDS];
         uint8_t sb[SHA3_KECCAK_SPONGE_WORDS * 8];
     } XXXXX;