zlib errors after upgrading to 2.3.11.3

[Timo Sirainen]

> 
> On 8. Sep 2020, at 12.35, Robert Nowotny <rnowotny1966 at gmail.com <mailto:rnowotny1966 at gmail.com>> wrote:
>> 
>> 
>> Dear Aki,
>> I switched to "gz" now, since "zstd" also gave some errors on writing to files.
> 
> What kind of errors?

Probably this? :

Panic: file ostream.c: line 287 (o_stream_sendv_int): assertion failed: (!stream->blocking)

>> Sep  3 08:33:25 lxc-imap dovecot: imap(mpaul)<48684><2/9E5mKuAezAqKjk>: Error: Mailbox Sent: UID=2171: read(zlib(/home/vmail/virtualmailboxes/mpaul/storage/m.119)) failed: read(/home/vmail/virtualmailboxes/mpaul/storage/m.119) failed: Broken pipe (FETCH BODY[])
> 
> Also this way you can see if the broken mail is actually xz or zstd or zlib. It would be nice to know if there are any zstd or zlib compressed mails that have problems. We did a lot of stress testing with zstd and also with xz, but haven't been able to reproduce any problems. It's also strange that it says taht the error is "Broken pipe" - that doesn't indicate that the mail is corrupted but that there is something more strange going on. So perhaps you don't actually have any mails written as corrupted, but Dovecot is just somehow having trouble reading the mails.

I managed to reproduce this. The files aren't corrupted, it's just that reading is failing. The attached patch should fix the xz code and should make your files readable again.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://dovecot.org/pipermail/dovecot/attachments/20200908/2e97e478/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff
Type: application/octet-stream
Size: 667 bytes
Desc: not available
URL: <https://dovecot.org/pipermail/dovecot/attachments/20200908/2e97e478/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://dovecot.org/pipermail/dovecot/attachments/20200908/2e97e478/attachment-0001.html>