11 Nov
2008
11 Nov
'08
1:13 p.m.
On Tue, 2008-11-11 at 01:16 +0100, Eugene wrote:
Thanks, I've added the Makefile patch, but the other one I'm not too sure about, it seems it would print things twice if the loop actually looped, so I left it for now. Also, your code can access buf[sizeof(buf)] which would be a buffer overrun.
My idea was that if the loop actually loops (i.e. more that 1024 bytes returned), we just log several lines in debug log. Sorry for buffer overrun, we have to check readsize of course. Or just pass sizeof(buf)-1 to read()
Yeah, somehow I got confused, I've added this now.
johannes