Hi Stephan, I had a problem while compiling 0.1.0 libsieve with gcc3.4. --- /usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments --- I propose a patch: $ cat dovecot-1.2-libsieve-gcc34.patch diff -ur dovecot1.2-libsieve-v1.2.orig/src/sieve-bin/bin-common.c dovecot1.2-libsieve-v1.2/src/sieve-bin/bin-common.c --- dovecot1.2-libsieve-v1.2.orig/src/sieve-bin/bin-common.c 2008-10-28 21:37:16 +0000 +++ dovecot1.2-libsieve-v1.2/src/sieve-bin/bin-common.c 2008-10-28 21:24:57 +0000 @@ -116,7 +116,7 @@ if ( strcmp(filename, "-") == 0 ) dumpstream = o_stream_create_fd(1, 0, FALSE); else { - if ( (dfd = open(filename, O_WRONLY | O_CREAT)) < 0 ) { + if ( (dfd = open(filename, O_WRONLY | O_CREAT, 0660)) < 0 ) { i_fatal("Failed to open dump-file for writing: %m"); exit(1); } diff -ur dovecot1.2-libsieve-v1.2.orig/src/testsuite/testsuite.c dovecot1.2-libsieve-v1.2/src/testsuite/testsuite.c --- dovecot1.2-libsieve-v1.2.orig/src/testsuite/testsuite.c 2008-10-28 21:37:16 +0000 +++ dovecot1.2-libsieve-v1.2/src/testsuite/testsuite.c 2008-10-28 21:35:18 +0000 @@ -119,7 +119,7 @@ if ( strcmp(filename, "-") == 0 ) dumpstream = o_stream_create_fd(1, 0, FALSE); else { - if ( (dfd = open(filename, O_WRONLY | O_CREAT)) < 0 ) { + if ( (dfd = open(filename, O_WRONLY | O_CREAT, 0660)) < 0 ) { i_fatal("Failed to open dump-file for writing: %m"); exit(1); } -- Sergey Ivanov. ----- "Stephan Bosch" <stephan@rename-it.nl> wrote:
Hello Dovecot users,
Finally, after little more than a year, I finished the first release of the new Sieve implementation for Dovecot. [skip] Have fun testing the new Sieve plugin. Don't hesitate to notify me when there are problems.
Regards,
-- Stephan Bosch stephan@rename-it.nl IRC: Freenode, #dovecot, S[r]us