On 01/20/2010 04:49 AM, Timo Sirainen wrote:
On 20.1.2010, at 11.45, Timo Sirainen wrote:
On 12.1.2010, at 16.47, Timo Sirainen wrote:
So there's something weird going on why it's in the filename hash table, but not in the array. I'll try to figure it out later..
This should fix it (and hopefully doesn't expose another bug): http://hg.dovecot.org/dovecot-1.2/rev/a1177c6cf8c7
I think that fixes all of the "duplicate entry in uidlist" errors that have been reported recently. So please test soon and report how it goes over a few days, and I'll release 1.2.10.
That seems to have done the trick. I've been running it for the past two hours in production and have not seen a single dump. The behavior looks like it handles it correctly now rather than dumping. I'll report back in a day or two to confirm that it has been stable, but so far so good. Thank you very much Timo.
Here's an example of stale nfs -> duplicate files instance with the patch...
Jan 20 13:06:17 gehenna14.rutgers.edu dovecot: IMAP(user): fdatasync(/rci/nqu/rci/u2/user/dovecot/.INBOX/dovecot-uidlist) failed: Stale NFS file handle Jan 20 13:06:17 gehenna14.rutgers.edu dovecot: IMAP(user): /rci/nqu/rci/u2/user/dovecot/.INBOX/dovecot-uidlist: next_uid was lowered (9531 -> 8975, hdr=8975) Jan 20 13:13:59 gehenna13.rutgers.edu dovecot: IMAP(user): /rci/nqu/rci/u2/user/dovecot/.INBOX/dovecot-uidlist: Duplicate file entry at line 3: 1259771459.M806388P24066V04240001I002E8FC6_0.gehenna7.rutgers.edu,S=3927:2,S (uid 8420 -> 9532) Jan 20 13:13:59 gehenna13.rutgers.edu dovecot: IMAP(user): /rci/nqu/rci/u2/user/dovecot/.INBOX/dovecot-uidlist: Duplicate file entry at line 4: 1259771993.M755737P14220V045C0002I002E8FC7_0.gehenna8.rutgers.edu,S=2768:2,S (uid 8421 -> 9533) ##### SNIP ##### Jan 20 13:13:59 gehenna13.rutgers.edu dovecot: IMAP(user): /rci/nqu/rci/u2/user/dovecot/.INBOX/dovecot-uidlist: Duplicate file entry at line 330: 1261199619.M995718P21199V03E80002I00B1AC1D_0.gehenna9.rutgers.edu,S=18949:2,Sa (uid 8747 -> 9859)
Notice it's dump free at the end! ;)