3 Oct
2012
3 Oct
'12
4:33 p.m.
Am 03.10.2012 02:50, schrieb Timo Sirainen:
On Wed, 2012-10-03 at 02:10 +0200, Florian Zeitz wrote:
Attached is a new export incorporating your feedback.
Committed. Also what do you think about the attached patch? (Compiles, untested.)
Moving the passdb parsing into a separate function seems like a nice idea to me. Style changes and removing an unused variable is obviously fine (I'm a bit surprised I got no compiler warning about the latter, but oh well).
I did a quick test. Login and error checking seem to still work fine with this patch in place. Wouldn't have seen anything in the code to suggest otherwise either.