Re: [Dovecot] Released 1.0.rc31

On Mon, 2007-04-09 at 09:07 -0400, Justin McAleer wrote:

Moving the dotlock creation after a successful call to mail_storage_create_with_data makes everything happy, but I defer to you whether it's safe to call that before locking.

Hmm. I guess that'd work. I'm not touching v1.0 anymore, but done to CVS HEAD: http://dovecot.org/list/dovecot-cvs/2007-April/008624.html

Here's the diff:

Please use diff -u whenever sending diffs. The default diff format is horrible to read.

Anyway I think it's not really correct, because this needs to be done after locking (although it's pretty unlikely to happen):

/* just in case if another process just had converted the mailbox,
   reopen the source storage */
mail_storage_destroy(&source_ns->storage);
if (mail_storage_create(source_ns, NULL, source_data, user,
			src_flags, lock_method) < 0) {
	/* No need for conversion anymore. */
	file_dotlock_delete(&dotlock);
	return 0;
}