On 03/06/2022 05:09 Dmitriy Fitisov dmitriy@radier.ca wrote:
Hello all again, building from 2.3.19 src tarball on Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:29 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T8101 arm64 got failure:
ioloop-notify-kqueue.c:70:2:error:implicit declaration of function 'i_gettimeofday' is invalid in C99 [-Werror,-Wimplicit-function-declaration] i_gettimeofday(&ioloop_timeval); ^ ioloop-notify-kqueue.c:70:2:note:did you mean 'gettimeofday'? /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/time.h:197:9:note:'gettimeofday' declared here int gettimeofday(struct timeval * __restrict, void * __restrict); ^ 1 error generated.
Not sure what is a proper way to report patches. Seem source generated by bison? Anyway, just added one liner added tosrc/lib/ioloop-notify-kqueue.c: 13a14
#include "time-util.h”
Builds fine. Thank you. Dmitriy
We have now finally merged this fix: https://github.com/dovecot/core/commit/e983ead775671186b3c8567d59973d2e52b67...
Aki Tuomi