Re: [Dovecot] Memory leak by getting the virtual size of a IMAP folder

On 6.9.2012, at 19.19, Dafan Zhai wrote:

I think I have fixed this bug. The 'virtual_size_add_new' function in src/lib-storage/index/index-status.c creates a 'search_args' object and forgets to free it at the end. The function does call the 'mailbox_search_deinit' function but 'mailbox_search_deinit' only frees the 'search_ctx' object and reduce the refcount of 'search_args' by one but that doesn't cause 'search_args' to be freed because its refcount was 2. So an extra 'mail_search_args_unref' must be called.

Timo, it would be nice if you could write a small comment if the attached patch is the right approach to address this issue.

Yes, committed to hg.