14 Jan
2024
14 Jan
'24
2:33 p.m.
I've recently upgraded to dovecot 2.3 and now my error.log is full of this message: dovecot: auth: Error: auth client 0 disconnected with 1 pending requests: EOF In earlier versions, this error was logged at a warning level. What is the rationale behind the elevation to error log level? May I suggest to revert this change?
(fyi: the code in question is in /src/auth/auth-client-connection.c)
static void auth_client_disconnected(struct auth_client_connection **_conn) { struct auth_client_connection *conn = *_conn; unsigned int request_count; int err;
*_conn = NULL;
if (conn->input->stream_errno != 0)
err = conn->input->stream_errno;
else if (conn->output->stream_errno != 0)
err = conn->output->stream_errno;
else
err = 0;
request_count = conn->request_handler == NULL ? 0 :
auth_request_handler_get_request_count(conn->request_handler);
if (request_count > 0) {
e_error(conn->event, "auth client %u disconnected with %u "
"pending requests: %s", conn->pid, request_count,
err == 0 ? "EOF" : strerror(err));
}
auth_client_connection_destroy(&conn);
}