On Thu, 2004-12-16 at 15:36 +0100, Johannes Berg wrote:
attached patch makes dovecot build on cygwin (only have a windows computer at the moment :-/ )
It spews a lot of warnings, for example "unsigned int format but uint32_t argument".
Well.. unsigned int and uint32_t are equilevant in most systems, and if int was changed into 64bit integer, it would still work.. Only in 16bit systems it would break but I don't even try to support them. Would be better if it didn't complain about those at all, casting them would be just annoying.
diff -ur --strip-trailing-cr dovecot-1.0-test58/src/lib-index/mail-cache-decisions.c dovecot-1.0-test58.mod/src/lib-index/mail-cache-decisions.c --- dovecot-1.0-test58/src/lib-index/mail-cache-decisions.c 2004-11-24 19:40:17.000000000 +0100 +++ dovecot-1.0-test58.mod/src/lib-index/mail-cache-decisions.c 2004-12-16 15:31:24.659497600 +0100 @@ -71,7 +71,7 @@ #include "mail-cache-private.h"
void mail_cache_decision_lookup(struct mail_cache_view *view, uint32_t seq, - unsigned int field) + uint32_t field) { struct mail_cache *cache = view->cache; const struct mail_index_header *hdr; @@ -115,7 +115,7 @@ }
void mail_cache_decision_add(struct mail_cache_view *view, uint32_t seq, - unsigned int field) + uint32_t field) { struct mail_cache *cache = view->cache; uint32_t uid;
Why these? They are called with unsigned int parameter and I can't really think of any other reasons why these should be changed. Doesn't it really compile without?
diff -ur --strip-trailing-cr dovecot-1.0-test58/src/util/dovecotpw.c dovecot-1.0-test58.mod/src/util/dovecotpw.c --- dovecot-1.0-test58/src/util/dovecotpw.c 2004-07-30 05:16:23.000000000 +0200 +++ dovecot-1.0-test58.mod/src/util/dovecotpw.c 2004-12-16 15:34:03.818356800 +0100 @@ -7,7 +7,6 @@
#include
#include -#include #include #include #include
I actually had changed configure to check for that header, but I had forgotten to add #ifdefs around it. Fixed.